Sign upLogin

betagouv/service-national-universel

View on GitHub
Star
api/src/referent/referentController.ts

Summary

Maintainability
F
3 days
Test Coverage

File referentController.ts has 1553 lines of code (exceeds 700 allowed). Consider refactoring.
Open

import express, { Response } from "express";
import { logger } from "../logger";
import passport from "passport";
import crypto from "crypto";
import jwt from "jsonwebtoken";
Severity: Major
Found in api/src/referent/referentController.ts - About 2 days to fix

    Consider simplifying this complex logical expression.
    Open

        if (payload.source === YOUNG_SOURCE.CLE) {
      const correctionRequestsFiltered = young?.correctionRequests?.filter((correction) => correction.field !== "CniFile") || [];
      young.set({
        source: YOUNG_SOURCE.CLE,
        etablissementId: payload.etablissementId,
    Severity: Critical
    Found in api/src/referent/referentController.ts - About 2 hrs to fix

      Function updateTutorNameInMissionsAndApplications has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      async function updateTutorNameInMissionsAndApplications(tutor, fromUser) {
  if (!tutor || !tutor.firstName || !tutor.lastName) return;

  const missions = await MissionModel.find({ tutorId: tutor._id });
  // Update missions
      Severity: Minor
      Found in api/src/referent/referentController.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function populateReferent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      async function populateReferent(ref) {
  if (ref.subRole === SUB_ROLES.referent_etablissement) {
    const etablissement = await EtablissementModel.findOne({ referentEtablissementIds: ref._id }).lean();
    if (!etablissement) throw new Error(ERRORS.NOT_FOUND);
    // Do not return res.status(404).send() in a helper function, only at the root of the route handler.
      Severity: Minor
      Found in api/src/referent/referentController.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status