Sign upLogin

betagt/useraclmanager

View on GitHub
Star
src/Http/Controllers/Api/RoleController.php

Summary

Maintainability
D
2 days
Test Coverage

Method assocRuleUser has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function assocRuleUser(Request $request){
        $data = $request->all();
        Validator::make($data, [
            'role_id' => [
                'required',
Severity: Minor
Found in src/Http/Controllers/Api/RoleController.php - About 1 hr to fix

    Method syncPermissions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function syncPermissions(Request $request){
        $data = $request->all();
        $rules = [
            'role_id' => [
                'required',
    Severity: Minor
    Found in src/Http/Controllers/Api/RoleController.php - About 1 hr to fix

      Method syncRoles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function syncRoles(Request $request){
        $data = $request->all();
        $rules = [
            'user_id' => [
                'required',
      Severity: Minor
      Found in src/Http/Controllers/Api/RoleController.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function syncPermissions(Request $request){
        $data = $request->all();
        $rules = [
            'role_id' => [
                'required',
        Severity: Major
        Found in src/Http/Controllers/Api/RoleController.php and 1 other location - About 5 hrs to fix
        src/Http/Controllers/Api/RoleController.php on lines 209..239

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 191.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function syncRoles(Request $request){
        $data = $request->all();
        $rules = [
            'user_id' => [
                'required',
        Severity: Major
        Found in src/Http/Controllers/Api/RoleController.php and 1 other location - About 5 hrs to fix
        src/Http/Controllers/Api/RoleController.php on lines 169..200

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 191.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                Validator::make($data, [
            'role_id' => [
                'required',
                'exists:roles,id',
                'integer',
        Severity: Major
        Found in src/Http/Controllers/Api/RoleController.php and 1 other location - About 4 hrs to fix
        src/Http/Controllers/Api/PermissionController.php on lines 164..183

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 165.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function update(RoleRequest $roleRequest,$id){
        $data = $roleRequest->all();
        try{
            return $this->roleRepository->update($data,$id);
        }
        Severity: Minor
        Found in src/Http/Controllers/Api/RoleController.php and 1 other location - About 40 mins to fix
        src/Http/Controllers/Api/PermissionController.php on lines 124..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public function destroy($id){
        try{
            $this->roleRepository->delete($id);
            return parent::responseSuccess(parent::HTTP_CODE_OK, parent::MSG_REGISTRO_EXCLUIDO);
        }
        Severity: Minor
        Found in src/Http/Controllers/Api/RoleController.php and 2 other locations - About 40 mins to fix
        src/Http/Controllers/Api/PermissionController.php on lines 142..153
        src/Http/Controllers/Api/UserController.php on lines 265..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status