betajs/betajs-media

View on GitHub

Showing 167 of 167 total issues

File webrtc_recorder.js has 958 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Scoped.define("module:WebRTC.RecorderWrapper", [
    "base:Classes.ConditionalInstance",
    "base:Events.EventsMixin",
    "base:Objs",
    "base:Async",
Severity: Major
Found in src/webrtc/webrtc_recorder.js - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (this._element.tagName.toLowerCase() !== "video") {
                        this._element = Dom.changeTag(this._element, "video");
                        this._transitionals.element = this._element;
                    } else if (ie9) {
                        var str = Strings.splitLast(this._element.outerHTML, "</video>").head;
    Severity: Major
    Found in src/video_player/video_player.js and 1 other location - About 1 day to fix
    src/audio_player/audio_player.js on lines 198..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 263.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (this._element.tagName.toLowerCase() !== "audio") {
                        this._element = Dom.changeTag(this._element, "audio");
                        this._transitionals.element = this._element;
                    } else if (ie9) {
                        var str = Strings.splitLast(this._element.outerHTML, "</audio>").head;
    Severity: Major
    Found in src/audio_player/audio_player.js and 1 other location - About 1 day to fix
    src/video_player/video_player.js on lines 275..289

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 263.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function userMedia2 has 242 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            userMedia2: function(options) {
                var opts = {};
                var promise;
                if (options.audio)
                    opts.audio = options.audio;
    Severity: Major
    Found in src/webrtc/webrtc_support.js - About 1 day to fix

      File video_player.js has 524 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      Scoped.define("module:Player.VideoPlayerWrapper", [
          "base:Classes.OptimisticConditionalInstance",
          "base:Events.EventsMixin",
          "base:MediaTypes",
          "base:Types",
      Severity: Major
      Found in src/video_player/video_player.js - About 1 day to fix

        File webrtc_support.js has 516 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        Scoped.define("module:WebRTC.Support", [
            "base:Promise",
            "base:Objs",
            "browser:Info",
            "browser:Dom",
        Severity: Major
        Found in src/webrtc/webrtc_support.js - About 1 day to fix

          File video_recorder.js has 445 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          Scoped.define("module:Recorder.VideoRecorderWrapper", [
              "base:Classes.ConditionalInstance",
              "base:Events.EventsMixin",
              "base:Objs",
              "base:Promise"
          Severity: Minor
          Found in src/video_recorder/video_recorder.js - About 6 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (Info.isSafari() && (Info.safariVersion() > 5 || Info.safariVersion() < 9)) {
                                if (this._element.networkState === this._element.NETWORK_LOADING) {
                                    Async.eventually(function() {
                                        if (!this.destroyed() && this._element.networkState === this._element.NETWORK_LOADING && this._element.buffered.length === 0)
                                            this._eventError(this.cls.ERROR_NO_PLAYABLE_SOURCE);
            Severity: Major
            Found in src/audio_player/audio_player.js and 1 other location - About 6 hrs to fix
            src/video_player/video_player.js on lines 461..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 165.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (Info.isSafari() && (Info.safariVersion() > 5 || Info.safariVersion() < 9)) {
                                if (this._element.networkState === this._element.NETWORK_LOADING) {
                                    Async.eventually(function() {
                                        if (!this.destroyed() && this._element.networkState === this._element.NETWORK_LOADING && this._element.buffered.length === 0)
                                            this._eventError(this.cls.ERROR_NO_PLAYABLE_SOURCE);
            Severity: Major
            Found in src/video_player/video_player.js and 1 other location - About 6 hrs to fix
            src/audio_player/audio_player.js on lines 319..326

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 165.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        if (('vp9'.localeCompare(match) === 0) || ('vp8'.localeCompare(match) === 0) || ('h264'.localeCompare(match) === 0) ||
                                            ('red'.localeCompare(match) === 0) || ('ulpfec'.localeCompare(match) === 0) || ('rtx'.localeCompare(match) === 0)) {
                                            if (enhanceData.videoBitrate !== undefined) {
                                                sdpStrRet += 'a=fmtp:' + rtpmapID[1] + ' x-google-min-bitrate=' + (enhanceData.videoBitrate) + ';x-google-max-bitrate=' + (enhanceData.videoBitrate) + '\r\n';
                                            }
            Severity: Major
            Found in src/webrtc/peer_recorder.js and 1 other location - About 6 hrs to fix
            src/webrtc/peer_recorder.js on lines 204..209

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        if (('opus'.localeCompare(match) === 0) || ('isac'.localeCompare(match) === 0) || ('g722'.localeCompare(match) === 0) || ('pcmu'.localeCompare(match) === 0) ||
                                            ('pcma'.localeCompare(match) === 0) || ('cn'.localeCompare(match) === 0)) {
                                            if (enhanceData.audioBitrate !== undefined) {
                                                sdpStrRet += 'a=fmtp:' + rtpmapID[1] + ' x-google-min-bitrate=' + (enhanceData.audioBitrate) + ';x-google-max-bitrate=' + (enhanceData.audioBitrate) + '\r\n';
                                            }
            Severity: Major
            Found in src/webrtc/peer_recorder.js and 1 other location - About 6 hrs to fix
            src/webrtc/peer_recorder.js on lines 197..202

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    createSnapshotDisplay: function(parent, snapshot, x, y, w, h) {
                        var url = Support.globals().URL.createObjectURL(snapshot);
                        var image = document.createElement("img");
                        image.style.position = "absolute";
                        this.updateSnapshotDisplay(snapshot, image, x, y, w, h);
            Severity: Major
            Found in src/video_recorder/recorder_support.js and 1 other location - About 5 hrs to fix
            src/video_recorder/video_recorder.js on lines 347..358

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 143.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        createSnapshotDisplay: function(parent, snapshot, x, y, w, h) {
                            var url = Support.globals().URL.createObjectURL(snapshot);
                            var image = document.createElement("img");
                            image.style.position = "absolute";
                            this.updateSnapshotDisplay(snapshot, image, x, y, w, h);
            Severity: Major
            Found in src/video_recorder/video_recorder.js and 1 other location - About 5 hrs to fix
            src/video_recorder/recorder_support.js on lines 217..228

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 143.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function _initialize has 119 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        _initialize: function() {
                            if (this._options.nohtml5)
                                return Promise.error(true);
                            if (this._sources.length < 1)
                                return Promise.error(true);
            Severity: Major
            Found in src/video_player/video_player.js - About 4 hrs to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          blankLevel: function(samples, areas) {
                              this._prepareCanvas();
                              areas = areas || this._areas;
                              if (areas.length === 1) return this._singleBlankLevel(samples, areas[0]);
                              var result = [];
              Severity: Major
              Found in src/common/video.js and 2 other locations - About 4 hrs to fix
              src/common/video.js on lines 59..68
              src/common/video.js on lines 95..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          lightLevel: function(samples, areas) {
                              this._prepareCanvas();
                              areas = areas || this._areas;
                              if (areas.length === 1) return this._singleLightLevel(samples, areas[0]);
                              var result = [];
              Severity: Major
              Found in src/common/video.js and 2 other locations - About 4 hrs to fix
              src/common/video.js on lines 77..86
              src/common/video.js on lines 95..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          deltaCoefficient: function(samples, areas) {
                              this._prepareCanvas();
                              areas = areas || this._areas;
                              if (areas.length === 1) return this._singleDeltaCoefficient(samples, areas[0]);
                              var result = [];
              Severity: Major
              Found in src/common/video.js and 2 other locations - About 4 hrs to fix
              src/common/video.js on lines 59..68
              src/common/video.js on lines 77..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (source.kind.indexOf("video") === 0) {
                                      result.videoCount++;
                                      if (typeof source.getCapabilities !== 'undefined')
                                          _sourceCapabilities = source.getCapabilities();
                                      result.video[source.id || source.deviceId] = {
              Severity: Major
              Found in src/webrtc/webrtc_support.js and 1 other location - About 4 hrs to fix
              src/webrtc/webrtc_support.js on lines 96..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (source.kind.indexOf("audio") === 0) {
                                      result.audioCount++;
                                      if (typeof source.getCapabilities !== 'undefined')
                                          _sourceCapabilities = source.getCapabilities();
                                      result.audio[source.id || source.deviceId] = {
              Severity: Major
              Found in src/webrtc/webrtc_support.js and 1 other location - About 4 hrs to fix
              src/webrtc/webrtc_support.js on lines 86..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _initialize has 97 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          _initialize: function() {
                              if (this._options.nohtml5)
                                  return Promise.error(true);
                              if (this._sources.length < 1)
                                  return Promise.error(true);
              Severity: Major
              Found in src/audio_player/audio_player.js - About 3 hrs to fix
                Severity
                Category
                Status
                Source
                Language