Sign upLogin

betajs/betajs-richeditor

View on GitHub
Star

Showing 5 of 5 total issues

File dynamic.js has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Scoped.define("module:Richeditor", [
    "dynamics:Dynamic",
    "base:Strings",
    "browser:Dom",
    "browser:Events",
Severity: Minor
Found in src/dynamic.js - About 2 hrs to fix

    Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

    var pkg = grunt.file.readJSON('package.json');
    var gruntHelper = require('betajs-compile');
    var dist = 'betajs-richeditor';
    Severity: Minor
    Found in Gruntfile.js - About 1 hr to fix

      Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  constructor: function (options) {
                inherited.constructor.call(this, options);
                this._domEvents = this.auto_destroy(new DomEvents());
                this.set("content", this.initialContent || "");
                this.__wasKeyInput = false;
      Severity: Minor
      Found in src/dynamic.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        while (current) {
                    if (current == element)
                        return true;
                    if (current == this.editor())
                        break;
        Severity: Minor
        Found in src/dynamic.js and 1 other location - About 30 mins to fix
        src/dynamic.js on lines 234..240

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        while (current) {
                    if (current == element)
                        return true;
                    if (current == this.editor())
                        break;
        Severity: Minor
        Found in src/dynamic.js and 1 other location - About 30 mins to fix
        src/dynamic.js on lines 210..216

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language