betajs/betajs-shims

View on GitHub

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function() {
    if (!this)
        return;
    this.addEventListener = this.addEventListener || Element.prototype.addEventListener;
    this.removeEventListener = this.removeEventListener || Element.prototype.removeEventListener;
Severity: Major
Found in src/legacy-event-listener-shim.js and 1 other location - About 5 hrs to fix
src/legacy-event-listener-shim.js on lines 97..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function() {
    if (!this)
        return;
    this.addEventListener = this.addEventListener || Element.prototype.addEventListener;
    this.removeEventListener = this.removeEventListener || Element.prototype.removeEventListener;
Severity: Major
Found in src/legacy-event-listener-shim.js and 1 other location - About 5 hrs to fix
src/legacy-event-listener-shim.js on lines 111..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.Map.prototype.keys = function() {
        return {
            current : this.__first,
            next : function() {
                var current = this.current;
Severity: Major
Found in src/es6-map-shim.js and 1 other location - About 3 hrs to fix
src/es6-map-shim.js on lines 81..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.Map.prototype.values = function() {
        return {
            current : this.__first,
            next : function() {
                var current = this.current;
Severity: Major
Found in src/es6-map-shim.js and 1 other location - About 3 hrs to fix
src/es6-map-shim.js on lines 63..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File array-shim.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function() {
    if (!this)
        return;

    // Production steps of ECMA-262, Edition 5, 15.4.4.18
Severity: Minor
Found in src/array-shim.js - About 3 hrs to fix

    Function reduce has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            this.reduce =function(callback /*, initialValue*/) {
                if (this === null) {
                    throw new TypeError( 'Array.prototype.reduce ' +
                      'called on null or undefined' );
                }
    Severity: Minor
    Found in src/array-shim.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if (func.call(thisArg, t[i], i, t))
                                  res[c++] = t[i];
      Severity: Major
      Found in src/array-shim.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (func(t[i], i, t))
                                    res[c++] = t[i];
        Severity: Major
        Found in src/array-shim.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language