beyond-blockchain/bbclib-go

View on GitHub
event.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method BBcEvent.Unpack has 7 return statements (exceeds 4 allowed).
Open

func (p *BBcEvent) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }

Severity: Major
Found in event.go - About 45 mins to fix

    Method BBcEvent.unpackApprovers has 6 return statements (exceeds 4 allowed).
    Open

    func (p *BBcEvent) unpackApprovers(buf *bytes.Buffer) error {
        numMandatory, err := Get2byte(buf)
        if err != nil {
            return err
        }
    Severity: Major
    Found in event.go - About 40 mins to fix

      Method BBcEvent.Pack has 5 return statements (exceeds 4 allowed).
      Open

      func (p *BBcEvent) Pack() ([]byte, error) {
          if len(p.OptionApprovers) != int(p.OptionApproverNumDenominator) {
              return nil, errors.New("num of option approvers must be equal to OptionApproverNumDenominator")
          }
          if p.AssetGroupID == nil {
      Severity: Major
      Found in event.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (p *BBcEvent) CreateAsset(userId *[]byte, fileContent *[]byte, bodyContent interface{}) *BBcEvent {
            obj := BBcAsset{Version: p.Version}
            obj.SetIdLengthConf(p.IdLengthConf)
            obj.Add(userId)
            if fileContent != nil {
        Severity: Major
        Found in event.go and 1 other location - About 1 hr to fix
        relation.go on lines 98..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            if p.Asset != nil {
                ast, err := p.Asset.Pack()
                if err != nil {
                    return nil, err
                }
        Severity: Major
        Found in event.go and 3 other locations - About 40 mins to fix
        relation.go on lines 164..175
        relation.go on lines 178..189
        relation.go on lines 191..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status