beyond-blockchain/bbclib-go

View on GitHub

Showing 22 of 32 total issues

Method BBcPointer.Unpack has 5 return statements (exceeds 4 allowed).
Open

func (p *BBcPointer) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }

Severity: Major
Found in pointer.go - About 35 mins to fix

    Method BBcTransaction.packBase has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
        Put4byte(buf, p.Version)
        if p.Timestamp == 0 {
            p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
        }
    Severity: Minor
    Found in transaction.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language