Sign upLogin

beyond-blockchain/bbclib-go

View on GitHub
Star
relation.go

Summary

Maintainability
C
1 day
Test Coverage

Method BBcRelation.Pack has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (p *BBcRelation) Pack() ([]byte, error) {
    if p.AssetGroupID == nil {
        return nil, errors.New("need asset_group_id in BBcRelation")
    }
    buf := new(bytes.Buffer)
Severity: Minor
Found in relation.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method BBcRelation.Unpack has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *BBcRelation) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }
Severity: Minor
Found in relation.go - About 1 hr to fix

    Method BBcRelation.Pack has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (p *BBcRelation) Pack() ([]byte, error) {
    if p.AssetGroupID == nil {
        return nil, errors.New("need asset_group_id in BBcRelation")
    }
    buf := new(bytes.Buffer)
    Severity: Minor
    Found in relation.go - About 1 hr to fix

      Method BBcRelation.Unpack has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

      func (p *BBcRelation) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }
      Severity: Minor
      Found in relation.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method BBcRelation.Unpack has 10 return statements (exceeds 4 allowed).
      Open

      func (p *BBcRelation) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }
      Severity: Major
      Found in relation.go - About 1 hr to fix

        Method BBcRelation.Pack has 10 return statements (exceeds 4 allowed).
        Open

        func (p *BBcRelation) Pack() ([]byte, error) {
    if p.AssetGroupID == nil {
        return nil, errors.New("need asset_group_id in BBcRelation")
    }
    buf := new(bytes.Buffer)
        Severity: Major
        Found in relation.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (p *BBcRelation) CreateAsset(userId *[]byte, fileContent *[]byte, bodyContent interface{}) *BBcRelation {
    obj := BBcAsset{Version: p.Version}
    obj.SetIdLengthConf(p.IdLengthConf)
    obj.Add(userId)
    if fileContent != nil {
          Severity: Major
          Found in relation.go and 1 other location - About 1 hr to fix
          event.go on lines 148..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 157.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if p.Asset != nil {
        ast, er := p.Asset.Pack()
        if er != nil {
            return nil, er
        }
          Severity: Major
          Found in relation.go and 3 other locations - About 40 mins to fix
          event.go on lines 190..201
          relation.go on lines 178..189
          relation.go on lines 191..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if p.AssetRaw != nil {
            ast, er := p.AssetRaw.Pack()
            if er != nil {
                return nil, er
            }
          Severity: Major
          Found in relation.go and 3 other locations - About 40 mins to fix
          event.go on lines 190..201
          relation.go on lines 164..175
          relation.go on lines 191..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if p.AssetHash != nil {
            ast, er := p.AssetHash.Pack()
            if er != nil {
                return nil, er
            }
          Severity: Major
          Found in relation.go and 3 other locations - About 40 mins to fix
          event.go on lines 190..201
          relation.go on lines 164..175
          relation.go on lines 178..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status