Sign upLogin

bflad/knife-cisco_asa

View on GitHub
Star

Showing 8 of 8 total issues

Method run has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run
        $stdout.sync = true
        
        hostname = name_args.first
Severity: Minor
Found in lib/chef/knife/cisco_asa_host_add.rb - About 2 hrs to fix

    Method run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run
        $stdout.sync = true
        
        hostname = name_args.first.upcase
    Severity: Minor
    Found in lib/chef/knife/cisco_asa_host_remove.rb - About 1 hr to fix

      Method included has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.included(includer)
        includer.class_eval do

          deps do
            require 'readline'
      Severity: Minor
      Found in lib/chef/knife/cisco_asa_base.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
        $stdout.sync = true
        
        hostname = name_args.first
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_add.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tcp_test_port has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def tcp_test_port(hostname,port)
        tcp_socket = TCPSocket.new(hostname, port)
        readable = IO.select([tcp_socket], nil, nil, 5)
        if readable
          Chef::Log.debug("sshd accepting connections on #{hostname}, banner is #{tcp_socket.gets}") if port == 22
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_base.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if get_config(:groups)
          get_config(:groups).split(",").each do |group|
            ui.info "#{ui.color "Group:", :cyan} #{group}"
            commands << "object-group network #{group}"
            commands << "  no network-object object #{hostname}"
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_remove.rb and 1 other location - About 30 mins to fix
        lib/chef/knife/cisco_asa_host_add.rb on lines 84..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if get_config(:groups)
          get_config(:groups).split(",").each do |group|
            ui.info "#{ui.color "Group:", :cyan} #{group}"
            commands << "object-group network #{group}"
            commands << "  network-object object #{hostname}"
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_add.rb and 1 other location - About 30 mins to fix
        lib/chef/knife/cisco_asa_host_remove.rb on lines 54..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
        $stdout.sync = true
        
        hostname = name_args.first.upcase
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_remove.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language