Sign upLogin

bflad/knife-cisco_asa

View on GitHub
Star

Showing 6 of 8 total issues

Method run has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run
        $stdout.sync = true
        
        hostname = name_args.first
Severity: Minor
Found in lib/chef/knife/cisco_asa_host_add.rb - About 2 hrs to fix

    Method run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run
        $stdout.sync = true
        
        hostname = name_args.first.upcase
    Severity: Minor
    Found in lib/chef/knife/cisco_asa_host_remove.rb - About 1 hr to fix

      Method included has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.included(includer)
        includer.class_eval do

          deps do
            require 'readline'
      Severity: Minor
      Found in lib/chef/knife/cisco_asa_base.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
        $stdout.sync = true
        
        hostname = name_args.first
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_add.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tcp_test_port has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def tcp_test_port(hostname,port)
        tcp_socket = TCPSocket.new(hostname, port)
        readable = IO.select([tcp_socket], nil, nil, 5)
        if readable
          Chef::Log.debug("sshd accepting connections on #{hostname}, banner is #{tcp_socket.gets}") if port == 22
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_base.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
        $stdout.sync = true
        
        hostname = name_args.first.upcase
        Severity: Minor
        Found in lib/chef/knife/cisco_asa_host_remove.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language