Sign upLogin

biemond/biemond-orawls

View on GitHub
Star
lib/puppet/provider/bsu_patch/bsu_patch.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method bsu_patch has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def bsu_patch(action)
    user                = resource[:os_user]
    patch_name           = resource[:name]
    middleware_home_dir = resource[:middleware_home_dir]
    weblogic_home_dir   = resource[:weblogic_home_dir]
Severity: Minor
Found in lib/puppet/provider/bsu_patch/bsu_patch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bsu_status has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def bsu_status
    user                = resource[:os_user]
    patch_name           = resource[:name]
    middleware_home_dir = resource[:middleware_home_dir]
    weblogic_home_dir   = resource[:weblogic_home_dir]
Severity: Minor
Found in lib/puppet/provider/bsu_patch/bsu_patch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bsu_patch has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def bsu_patch(action)
    user                = resource[:os_user]
    patch_name           = resource[:name]
    middleware_home_dir = resource[:middleware_home_dir]
    weblogic_home_dir   = resource[:weblogic_home_dir]
Severity: Minor
Found in lib/puppet/provider/bsu_patch/bsu_patch.rb - About 1 hr to fix

    Method bsu_status has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def bsu_status
    user                = resource[:os_user]
    patch_name           = resource[:name]
    middleware_home_dir = resource[:middleware_home_dir]
    weblogic_home_dir   = resource[:weblogic_home_dir]
    Severity: Minor
    Found in lib/puppet/provider/bsu_patch/bsu_patch.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status