Sign upLogin

bigcommerce/gruf

View on GitHub
Star

Showing 25 of 26 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def insert_before(before_class, interceptor_class, options = {})
        interceptors_mutex do
          pos = @registry.find_index { |opts| opts.fetch(:klass, '') == before_class }
          raise InterceptorNotFoundError if pos.nil?
Severity: Minor
Found in lib/gruf/interceptors/registry.rb and 1 other location - About 25 mins to fix
lib/gruf/hooks/registry.rb on lines 66..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method reset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def reset
      VALID_CONFIG_KEYS.each do |k, v|
        send(:"#{k}=", v)
      end
      self.server_binding_url = "#{::ENV.fetch('GRPC_SERVER_HOST',
Severity: Minor
Found in lib/gruf/configuration.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deserialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def deserialize(exception)
        if exception.respond_to?(:metadata)
          key = exception.metadata.key?(@metadata_key.to_s) ? @metadata_key.to_s : @metadata_key.to_sym
          return @deserializer_class.new(exception.metadata[key]).deserialize if exception.metadata.key?(key)
        end
Severity: Minor
Found in lib/gruf/client/error_factory.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def call(method_key, &block)
        Interceptors::Context.new(@interceptors).intercept! do
          process_action(method_key, &block)
        end
      rescue GRPC::BadStatus
Severity: Minor
Found in lib/gruf/controllers/base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method determine_loggers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def determine_loggers
      if defined?(::Rails) && ::Rails.logger
        self.logger = ::Rails.logger
      else
        require 'logger'
Severity: Minor
Found in lib/gruf/configuration.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language