Sign upLogin

billybonks/pygmy

View on GitHub
Star

Showing 9 of 9 total issues

Function exports has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(token,id,secret,host){
  return {
    get:get,
    where:where,
    post:post,
Severity: Major
Found in request.js - About 4 hrs to fix

    Function exports has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(pygmy,route,request){
  var _onRequestError = function(reject){
    return function(error){
      reject(error);
    };
    Severity: Major
    Found in route.js - About 3 hrs to fix

      Function createRequest has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function createRequest(params,resolve,reject){// jshint ignore:line
    var req = https.request(_.merge(params,this.baseOptions), function(res) {
      var data = '';
      res.on('data', function(chunk) {
        data += chunk;
      Severity: Major
      Found in request.js - About 2 hrs to fix

        Function req has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var req = https.request(_.merge(params,this.baseOptions), function(res) {
      var data = '';
      res.on('data', function(chunk) {
        data += chunk;
      });
        Severity: Minor
        Found in request.js - About 1 hr to fix

          Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(route){
    var _data={};
    return {
      isDirty:false,
      build:function(params){
          Severity: Minor
          Found in model.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    }else{
          request.put(model.raw(),_self._path).then(_self._onUpdate.call(_self,resolve,model),_onRequestError(reject));
        }
            Severity: Minor
            Found in route.js and 1 other location - About 55 mins to fix
            route.js on lines 39..41

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if(model.raw().id){
          request.post(model.raw(),_self._path).then(_self._onUpdate.call(_self,resolve,model),_onRequestError(reject));
        }else{
            Severity: Minor
            Found in route.js and 1 other location - About 55 mins to fix
            route.js on lines 41..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function(token,id,secret,host){
  return {
    get:get,
    where:where,
    post:post,
            Severity: Minor
            Found in request.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function(route){
    var _data={};
    return {
      isDirty:false,
      build:function(params){
            Severity: Minor
            Found in model.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language