Sign upLogin

binhonglee/GlobeTrotte

View on GitHub
Star

Showing 49 of 49 total issues

Avoid deeply nested control flow statements.
Open

        if (General.confirmed()) {
          next(R.getNext(to));
        } else {
          next();
        }
Severity: Major
Found in src/cockpit/main.ts - About 45 mins to fix

    Function updateDay has 6 return statements (exceeds 4 allowed).
    Open

    func updateDay(
    updatedDay *wings.Day, createOnNonExist bool,
) bool {
    existingDay := fetchDay(int64(updatedDay.ID))
    if updatedDay.ID == -1 || existingDay.ID != updatedDay.ID {
    Severity: Major
    Found in src/turbine/database/tripdb.go - About 40 mins to fix

      Function init has 6 return statements (exceeds 4 allowed).
      Open

      func init() {
    configs := config.GetConfigStringMap("email")

    if !hasConfig {
        return
      Severity: Major
      Found in src/turbine/email/email.go - About 40 mins to fix

        Function updateTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            path string,
    t *testing.T,
    toAdd structs.IStructs,
    objType interface{},
    expectedCode int,
        Severity: Minor
        Found in src/turbine/router/router_test.go - About 35 mins to fix

          Function addTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              path string,
    t *testing.T,
    toAdd structs.IStructs,
    objType interface{},
    unmarshalBody bool,
          Severity: Minor
          Found in src/turbine/router/router_test.go - About 35 mins to fix

            Function getModuleInfo has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func getModuleInfo(name string, gmod *golistobj) gopkg {
    var mod golistobj
    if gmod == nil {
        res := runNoPanic("go", "list", "--json", name)
        if len(res) == 0 {
            Severity: Minor
            Found in src/turbine/scripts/genBUILD.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func getUserObj(res http.ResponseWriter, req *http.Request) {
    var id int
    if id = getRequestID(req); id == -1 {
        respond(res, user.DummyUserObj())
        return
            Severity: Minor
            Found in src/turbine/router/userhandlers.go and 1 other location - About 35 mins to fix
            src/turbine/router/triphandlers.go on lines 16..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func getTripObj(res http.ResponseWriter, req *http.Request) {
    var id int
    if id = getRequestID(req); id == -1 {
        respond(res, trip.DummyTripObj())
        return
            Severity: Minor
            Found in src/turbine/router/triphandlers.go and 1 other location - About 35 mins to fix
            src/turbine/router/userhandlers.go on lines 60..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              private getRoute(path: string, name: string, component: string): string {
    let metaTxt = "";
    for (const key of Object.keys(meta)) {
      if (
        meta[key].includes(name) ||
            Severity: Minor
            Found in src/cockpit/scripts/genRouter.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language