Sign upLogin

bitcoin/bitcoin

View on GitHub
Star
contrib/devtools/symbol-check.py

Summary

Maintainability
B
4 hrs
Test Coverage

File symbol-check.py has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python3
# Copyright (c) 2014 Wladimir J. van der Laan
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
'''
Severity: Minor
Found in contrib/devtools/symbol-check.py - About 2 hrs to fix

    Function check_imported_symbols has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def check_imported_symbols(binary) -> bool:
    ok: bool = True

    for symbol in binary.imported_symbols:
        if not symbol.imported:
    Severity: Minor
    Found in contrib/devtools/symbol-check.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function check_exported_symbols has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def check_exported_symbols(binary) -> bool:
    ok: bool = True

    for symbol in binary.dynamic_symbols:
        if not symbol.exported:
    Severity: Minor
    Found in contrib/devtools/symbol-check.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status