bitcoin/bitcoin

View on GitHub
contrib/seeds/makeseeds.py

Summary

Maintainability
C
1 day
Test Coverage

Function parseline has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

def parseline(line: str) -> Union[dict, None]:
    """ Parses a line from `seeds_main.txt` into a dictionary of details for that line.
    or `None`, if the line could not be parsed.
    """
    if line.startswith('#'):
Severity: Minor
Found in contrib/seeds/makeseeds.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def main():
    args = parse_args()

    print(f'Loading asmap database "{args.asmap}"…', end='', file=sys.stderr, flush=True)
    with open(args.asmap, 'rb') as f:
Severity: Minor
Found in contrib/seeds/makeseeds.py - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                    return None
    Severity: Major
    Found in contrib/seeds/makeseeds.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return None
      Severity: Major
      Found in contrib/seeds/makeseeds.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return {
        Severity: Major
        Found in contrib/seeds/makeseeds.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return None
          Severity: Major
          Found in contrib/seeds/makeseeds.py - About 30 mins to fix

            Function filterbyasn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def filterbyasn(asmap: ASMap, ips: list[dict], max_per_asn: dict, max_per_net: int) -> list[dict]:
                """ Prunes `ips` by
                (a) trimming ips to have at most `max_per_net` ips from each net (e.g. ipv4, ipv6); and
                (b) trimming ips to have at most `max_per_asn` ips from each asn in each net.
                """
            Severity: Minor
            Found in contrib/seeds/makeseeds.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def main():
                args = parse_args()
            
                print(f'Loading asmap database "{args.asmap}"…', end='', file=sys.stderr, flush=True)
                with open(args.asmap, 'rb') as f:
            Severity: Minor
            Found in contrib/seeds/makeseeds.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status