Sign upLogin

biter777/countries

View on GitHub
Star
callcodes.go

Summary

Maintainability
A
0 mins
Test Coverage

Method CallCode.Countries has 505 lines of code (exceeds 50 allowed). Consider refactoring.
Invalid

func (c CallCode) Countries() []CountryCode { //nolint:gocyclo
    switch c {
    case CallCode1:
        return []CountryCode{ATF, CAN, UMI, USA}
    case CallCode1808:
Severity: Major
Found in callcodes.go - About 2 days to fix

    File callcodes.go has 832 lines of code (exceeds 500 allowed). Consider refactoring.
    Invalid

    package countries

import (
    "encoding/json"
    "fmt"
    Severity: Major
    Found in callcodes.go - About 1 day to fix

      Function AllCallCodes has 266 lines of code (exceeds 50 allowed). Consider refactoring.
      Invalid

      func AllCallCodes() []CallCode {
    return []CallCode{
        CallCodeUnknown,
        CallCode1,
        CallCode7,
      Severity: Major
      Found in callcodes.go - About 1 day to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

        func (c *CallCodeInfo) Scan(src interface{}) error {
    if c == nil {
        return fmt.Errorf("countries::Scan: CallCodeInfo scan err: callCodeInfo == nil")
    }
    switch src := src.(type) {
        Severity: Major
        Found in callcodes.go and 5 other locations - About 45 mins to fix
        capitals.go on lines 1072..1085
        countries.go on lines 5451..5464
        currencies.go on lines 1646..1659
        domains.go on lines 103..116
        regions.go on lines 97..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        receiver name should not be an underscore, omit the name if it is unused
        Open

        func (_ CallCode) Type() string {
        Severity: Minor
        Found in callcodes.go by golint

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package countries
        Severity: Minor
        Found in callcodes.go by gofmt

        receiver name should not be an underscore, omit the name if it is unused
        Open

        func (_ *CallCodeInfo) Type() string {
        Severity: Minor
        Found in callcodes.go by golint

        There are no issues that match your filters.

        Category
        Status