Sign upLogin

biter777/countries

View on GitHub
Star
capitals.go

Summary

Maintainability
A
0 mins
Test Coverage

File capitals.go has 1827 lines of code (exceeds 500 allowed). Consider refactoring.
Invalid

package countries

import (
    "encoding/json"
    "fmt"
Severity: Major
Found in capitals.go - About 4 days to fix

    Method CapitalCode.String has 507 lines of code (exceeds 50 allowed). Consider refactoring.
    Invalid

    func (c CapitalCode) String() string { //nolint:gocyclo
    switch c {
    case CapitalAU:
        return "Canberra"
    case CapitalAT:
    Severity: Major
    Found in capitals.go - About 2 days to fix

      Method CapitalCode.Country has 507 lines of code (exceeds 50 allowed). Consider refactoring.
      Invalid

      func (c CapitalCode) Country() CountryCode { //nolint:gocyclo
    switch c {
    case CapitalAU:
        return AU
    case CapitalAT:
      Severity: Major
      Found in capitals.go - About 2 days to fix

        Function CapitalCodeByName has 495 lines of code (exceeds 50 allowed). Consider refactoring.
        Invalid

        func CapitalCodeByName(name string) CapitalCode { //nolint:gocyclo
    switch textPrepare(name) {
    case "ORANJESTAD":
        return CapitalAW
    case "STJOHNS":
        Severity: Major
        Found in capitals.go - About 2 days to fix

          Function AllCapitals has 255 lines of code (exceeds 50 allowed). Consider refactoring.
          Invalid

          func AllCapitals() []CapitalCode {
    return []CapitalCode{
        CapitalAU,
        CapitalAT,
        CapitalAZ,
          Severity: Major
          Found in capitals.go - About 1 day to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Invalid

            func (c *Capital) Scan(src interface{}) error {
    if c == nil {
        return fmt.Errorf("countries::Scan: Capital scan err: capital == nil")
    }
    switch src := src.(type) {
            Severity: Major
            Found in capitals.go and 5 other locations - About 45 mins to fix
            callcodes.go on lines 847..860
            countries.go on lines 5451..5464
            currencies.go on lines 1646..1659
            domains.go on lines 103..116
            regions.go on lines 97..110

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Your code does not pass gofmt in 3 places. Go fmt your code!
            Open

            package countries
            Severity: Minor
            Found in capitals.go by gofmt

            receiver name should not be an underscore, omit the name if it is unused
            Open

            func (_ CapitalCode) Type() string {
            Severity: Minor
            Found in capitals.go by golint

            receiver name should not be an underscore, omit the name if it is unused
            Open

            func (_ Capital) Type() string {
            Severity: Minor
            Found in capitals.go by golint

            There are no issues that match your filters.

            Category
            Status