Sign upLogin

bitovi/canjs

View on GitHub
Star

Showing 460 of 460 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  static props = {
    profiles: {
      get default() {
        return new ObservableArray([
          { name: "gru", img: "https://user-images.githubusercontent.com/78602/40454685-5cab196e-5eaf-11e8-87ac-4af6792994ed.jpg" },
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/6-show-nope.js and 1 other location - About 1 day to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/7-release.js on lines 28..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 231.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  static props = {
    profiles: {
      get default() {
        return new ObservableArray([
          { name: "gru", img: "https://user-images.githubusercontent.com/78602/40454685-5cab196e-5eaf-11e8-87ac-4af6792994ed.jpg" },
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/7-release.js and 1 other location - About 1 day to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/6-show-nope.js on lines 28..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 231.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  connected() {
    let current = this.querySelector(".current");
    let startingX;

    this.listenTo(current, "pointerdown", event => {
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/7-release.js and 1 other location - About 1 day to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/8-empty-profile.js on lines 83..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  connected() {
    let current = this.querySelector(".current");
    let startingX;

    this.listenTo(current, "pointerdown", event => {
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/8-empty-profile.js and 1 other location - About 1 day to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/7-release.js on lines 75..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  static props = {
    profiles: {
      get default() {
        return new ObservableArray([
          { name: "gru", img: "https://user-images.githubusercontent.com/78602/40454685-5cab196e-5eaf-11e8-87ac-4af6792994ed.jpg" },
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/2-like-btn.js and 1 other location - About 7 hrs to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/3-dislike-btn.js on lines 24..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 194.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  static props = {
    profiles: {
      get default() {
        return new ObservableArray([
          { name: "gru", img: "https://user-images.githubusercontent.com/78602/40454685-5cab196e-5eaf-11e8-87ac-4af6792994ed.jpg" },
Severity: Major
Found in docs/can-guides/commitment/recipes/tinder-like-carousel/3-dislike-btn.js and 1 other location - About 7 hrs to fix
docs/can-guides/commitment/recipes/tinder-like-carousel/2-like-btn.js on lines 23..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 194.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  get forecastPromise() {
    if (this.location && this.location.length > 2) {
      return fetch(
        yqlURL +
        can.param({
Severity: Major
Found in docs/can-guides/commitment/recipes/weather-report/advanced/4-enable-location.js and 4 other locations - About 7 hrs to fix
docs/can-guides/commitment/recipes/weather-report/advanced/1.js on lines 5..24
docs/can-guides/commitment/recipes/weather-report/advanced/2.js on lines 42..61
docs/can-guides/commitment/recipes/weather-report/advanced/3.js on lines 62..81
docs/can-guides/commitment/recipes/weather-report/advanced/5-show-location.js on lines 68..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  get forecastPromise() {
    if (this.location && this.location.length > 2) {
      return fetch(
        yqlURL +
        can.param({
Severity: Major
Found in docs/can-guides/commitment/recipes/weather-report/advanced/2.js and 4 other locations - About 7 hrs to fix
docs/can-guides/commitment/recipes/weather-report/advanced/1.js on lines 5..24
docs/can-guides/commitment/recipes/weather-report/advanced/3.js on lines 62..81
docs/can-guides/commitment/recipes/weather-report/advanced/4-enable-location.js on lines 65..84
docs/can-guides/commitment/recipes/weather-report/advanced/5-show-location.js on lines 68..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  get forecastPromise() {
    if (this.location && this.location.length > 2) {
      return fetch(
        yqlURL +
        can.param({
Severity: Major
Found in docs/can-guides/commitment/recipes/weather-report/advanced/3.js and 4 other locations - About 7 hrs to fix
docs/can-guides/commitment/recipes/weather-report/advanced/1.js on lines 5..24
docs/can-guides/commitment/recipes/weather-report/advanced/2.js on lines 42..61
docs/can-guides/commitment/recipes/weather-report/advanced/4-enable-location.js on lines 65..84
docs/can-guides/commitment/recipes/weather-report/advanced/5-show-location.js on lines 68..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  get forecastPromise() {
    if (this.location && this.location.length > 2) {
      return fetch(
        yqlURL +
        can.param({
Severity: Major
Found in docs/can-guides/commitment/recipes/weather-report/advanced/1.js and 4 other locations - About 7 hrs to fix
docs/can-guides/commitment/recipes/weather-report/advanced/2.js on lines 42..61
docs/can-guides/commitment/recipes/weather-report/advanced/3.js on lines 62..81
docs/can-guides/commitment/recipes/weather-report/advanced/4-enable-location.js on lines 65..84
docs/can-guides/commitment/recipes/weather-report/advanced/5-show-location.js on lines 68..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  get forecastPromise() {
    if (this.location && this.location.length > 2) {
      return fetch(
        yqlURL +
        can.param({
Severity: Major
Found in docs/can-guides/commitment/recipes/weather-report/advanced/5-show-location.js and 4 other locations - About 7 hrs to fix
docs/can-guides/commitment/recipes/weather-report/advanced/1.js on lines 5..24
docs/can-guides/commitment/recipes/weather-report/advanced/2.js on lines 42..61
docs/can-guides/commitment/recipes/weather-report/advanced/3.js on lines 62..81
docs/can-guides/commitment/recipes/weather-report/advanced/4-enable-location.js on lines 65..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class TodoListElement extends StacheElement {
  static view = `
    <ul id="todo-list">
      {{# for(todo of this.todos) }}
        <li class="todo {{# if(todo.complete) }}completed{{/ if }}
Severity: Major
Found in docs/can-guides/experiment/todomvc/7-edit/js.js and 2 other locations - About 7 hrs to fix
docs/can-guides/experiment/todomvc/8-routing/js.js on lines 80..136
docs/can-guides/experiment/todomvc/9-toggle/js.js on lines 104..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class TodoListElement extends StacheElement {
  static view = `
    <ul id="todo-list">
      {{# for(todo of this.todos) }}
        <li class="todo {{# if(todo.complete) }}completed{{/ if }}
Severity: Major
Found in docs/can-guides/experiment/todomvc/8-routing/js.js and 2 other locations - About 7 hrs to fix
docs/can-guides/experiment/todomvc/7-edit/js.js on lines 79..135
docs/can-guides/experiment/todomvc/9-toggle/js.js on lines 104..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

class TodoListElement extends StacheElement {
  static view = `
    <ul id="todo-list">
      {{# for(todo of this.todos) }}
        <li class="todo {{# if(todo.complete) }}completed{{/ if }}
Severity: Major
Found in docs/can-guides/experiment/todomvc/9-toggle/js.js and 2 other locations - About 7 hrs to fix
docs/can-guides/experiment/todomvc/7-edit/js.js on lines 79..135
docs/can-guides/experiment/todomvc/8-routing/js.js on lines 80..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var Deposit = Transaction.extend({
    amount: "number",
    isReady: function() {
        return typeof this.amount === "number" &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/atm.js and 1 other location - About 7 hrs to fix
docs/can-guides/experiment/atm/atm.js on lines 146..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var Withdrawal = Transaction.extend({
    amount: "number",
    isReady: function() {
        return typeof this.amount === "number" &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/atm.js and 1 other location - About 7 hrs to fix
docs/can-guides/experiment/atm/atm.js on lines 123..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

var Withdrawal = Transaction.extend({
    amount: "number",
    get ready() {
        return this.amount > 0 &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/5-transactions-models/js.js and 15 other locations - About 6 hrs to fix
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 143..164
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 166..187
docs/can-guides/experiment/atm/13-printing/js.js on lines 143..164
docs/can-guides/experiment/atm/13-printing/js.js on lines 166..187
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 143..164
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 143..164
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 166..187
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 143..164
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 166..187
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 143..164
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 166..187
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 143..164
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 166..187
docs/can-guides/experiment/atm/atm-stream.js on lines 143..164
docs/can-guides/experiment/atm/atm-stream.js on lines 166..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

var Withdrawal = Transaction.extend({
    amount: "number",
    get ready() {
        return this.amount > 0 &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/13-printing/js.js and 15 other locations - About 6 hrs to fix
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 143..164
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 166..187
docs/can-guides/experiment/atm/13-printing/js.js on lines 143..164
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 143..164
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 166..187
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 143..164
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 166..187
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 143..164
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 166..187
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 143..164
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 166..187
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 143..164
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 166..187
docs/can-guides/experiment/atm/atm-stream.js on lines 143..164
docs/can-guides/experiment/atm/atm-stream.js on lines 166..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

var Withdrawal = Transaction.extend({
    amount: "number",
    get ready() {
        return this.amount > 0 &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/6-reading-card/js.js and 15 other locations - About 6 hrs to fix
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 143..164
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 166..187
docs/can-guides/experiment/atm/13-printing/js.js on lines 143..164
docs/can-guides/experiment/atm/13-printing/js.js on lines 166..187
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 143..164
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 166..187
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 143..164
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 143..164
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 166..187
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 143..164
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 166..187
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 143..164
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 166..187
docs/can-guides/experiment/atm/atm-stream.js on lines 143..164
docs/can-guides/experiment/atm/atm-stream.js on lines 166..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

var Withdrawal = Transaction.extend({
    amount: "number",
    get ready() {
        return this.amount > 0 &&
            this.account &&
Severity: Major
Found in docs/can-guides/experiment/atm/7-reading-pin/js.js and 15 other locations - About 6 hrs to fix
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 143..164
docs/can-guides/experiment/atm/10-deposit-info/js.js on lines 166..187
docs/can-guides/experiment/atm/13-printing/js.js on lines 143..164
docs/can-guides/experiment/atm/13-printing/js.js on lines 166..187
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 143..164
docs/can-guides/experiment/atm/5-transactions-models/js.js on lines 166..187
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 143..164
docs/can-guides/experiment/atm/6-reading-card/js.js on lines 166..187
docs/can-guides/experiment/atm/7-reading-pin/js.js on lines 143..164
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 143..164
docs/can-guides/experiment/atm/8-choosing-transaction/js.js on lines 166..187
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 143..164
docs/can-guides/experiment/atm/9-picking-account/js.js on lines 166..187
docs/can-guides/experiment/atm/atm-stream.js on lines 143..164
docs/can-guides/experiment/atm/atm-stream.js on lines 166..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language