bitslip6/bitfire

Method onerr has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function onerr($errno, $errstr, $errfile, $errline, $context = NULL) : bool {

Method file_recurse has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function file_recurse(string $dirname, callable $fn, string $regex_filter = NULL, array $result = array(), $max_results = 20000) : array {

Function file_recurse defined at /code/bin/bitfire-install.php:128 was previously defined at /code/recovery.php:21

Open

function file_recurse(string $dirname, callable $fn, string $regex_filter = NULL, array $result = array(), $max_results = 20000) : array {

• Exclude checks
  • Disable engine
  • Disable check

Variable $params was undeclared, but array fields are being added to it.

Open

        $params['http']['content'] = $content;

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (expires) is array{expires:int,path:'/',domain:'',secure:false,httponly:true,samesite:'strict'} but \setcookie() takes int

Open

    if (PHP_VERSION_ID < 70300) { setcookie($name, $value, time() + $exp, '/; samesite=strict', '', false, true); } else { setcookie($name, $value, [ 'expires' => time() + $exp, 'path' => '/', 'domain' => '', 'secure' => false, 'httponly' => true, 'samesite' => 'strict' ]); }

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (expires) is array{expires:float|int,path:'/',domain:'',secure:false,httponly:true,samesite:'strict'} but \setcookie() takes int

Open

    if (PHP_VERSION_ID < 70300) { setcookie($name, $value, time() + $exp, '/; samesite=strict', '', false, true); } else { setcookie($name, $value, [ 'expires' => time() + $exp, 'path' => '/', 'domain' => '', 'secure' => false, 'httponly' => true, 'samesite' => 'strict' ]); }

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (var) is \Generator|\Iterator|\Traversable|iterable but \count() takes \Countable|array

Open

                    $result_count = count($result);

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if ($dh = \opendir($dirname)) {
        while(($file = \readdir($dh)) !== false && $maxfiles-- > 0 && $result_count < $max_results) {
            $path = $dirname . '/' . $file;
            if (!$file || $file === '.' || $file === '..') {
                continue;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    if (PHP_VERSION_ID < 70300) { setcookie($name, $value, time() + $exp, '/; samesite=strict', '', false, true); } else { setcookie($name, $value, [ 'expires' => time() + $exp, 'path' => '/', 'domain' => '', 'secure' => false, 'httponly' => true, 'samesite' => 'strict' ]); }

• Read up
  Read up