bitslip6/bitfire

View on GitHub
custom-plugin/includes.php

Summary

Maintainability
A
3 hrs
Test Coverage

Possibly zero references to use statement for function dbg (\ThreadFin\dbg)
Open

use function ThreadFin\dbg;
Severity: Minor
Found in custom-plugin/includes.php by phan

Possibly zero references to use statement for function ends_with (\ThreadFin\ends_with)
Open

use function ThreadFin\ends_with;
Severity: Minor
Found in custom-plugin/includes.php by phan

Doc-block of $name in path_to_source is phpdoc param type string which is not a permitted replacement of the nullable param type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

 * @param string $name     the plugin/theme/module name for the file 
Severity: Minor
Found in custom-plugin/includes.php by phan

mixed $args is not variadic in comment, but variadic in param (...$args)
Open

 * @param mixed $args 
Severity: Info
Found in custom-plugin/includes.php by phan

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function fn_audit(string $fn_name, string $file, string $line, ...$args) {
    static $fn_map = [
        "update_user_meta" => [1 => DST_USER, 2 => RISKY_DB_PARAM, 3=> PARAM_SEARCH],
        "wp_create_user" => [1 => LOG_ACTION],
        "wp_insert_user" => [1 => LOG_ACTION]
Severity: Major
Found in custom-plugin/includes.php and 1 other location - About 3 hrs to fix
wordpress-plugin/includes.php on lines 219..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status