Sign upLogin

biurad/flange

View on GitHub
Star
src/Database/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function getEntitiesByIds has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function getEntitiesByIds(string $identifier, array $values): array
    {
        if (null !== $this->queryBuilder->getMaxResults() || 0 < (int) $this->queryBuilder->getFirstResult()) {
            // an offset or a limit would apply on results including the where clause with submitted id values
            // that could make invalid choices valid
Severity: Minor
Found in src/Database/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getEntitiesByIds has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getEntitiesByIds(string $identifier, array $values): array
    {
        if (null !== $this->queryBuilder->getMaxResults() || 0 < (int) $this->queryBuilder->getFirstResult()) {
            // an offset or a limit would apply on results including the where clause with submitted id values
            // that could make invalid choices valid
Severity: Minor
Found in src/Database/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status