bizley/yii2-podium

View on GitHub
src/controllers/ForumThreadController.php

Summary

Maintainability
C
1 day
Test Coverage

Function actionMove has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionMove($cid = null, $fid = null, $id = null, $slug = null)
    {
        $thread = (new ThreadVerifier([
            'categoryId' => $cid,
            'forumId' => $fid,
Severity: Minor
Found in src/controllers/ForumThreadController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionMove has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionMove($cid = null, $fid = null, $id = null, $slug = null)
    {
        $thread = (new ThreadVerifier([
            'categoryId' => $cid,
            'forumId' => $fid,
Severity: Major
Found in src/controllers/ForumThreadController.php - About 2 hrs to fix

    Method actionNewThread has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionNewThread($cid = null, $fid = null)
        {
            if (!User::can(Rbac::PERM_CREATE_THREAD)) {
                $this->error(Yii::t('podium/flash', 'Sorry! You do not have the required permission to perform this action.'));
                return $this->redirect(['forum/index']);
    Severity: Minor
    Found in src/controllers/ForumThreadController.php - About 1 hr to fix

      Function actionNewThread has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionNewThread($cid = null, $fid = null)
          {
              if (!User::can(Rbac::PERM_CREATE_THREAD)) {
                  $this->error(Yii::t('podium/flash', 'Sorry! You do not have the required permission to perform this action.'));
                  return $this->redirect(['forum/index']);
      Severity: Minor
      Found in src/controllers/ForumThreadController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method actionDelete has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionDelete($cid = null, $fid = null, $id = null, $slug = null)
          {
              $thread = (new ThreadVerifier([
                  'categoryId' => $cid,
                  'forumId' => $fid,
      Severity: Minor
      Found in src/controllers/ForumThreadController.php - About 1 hr to fix

        Function actionDelete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionDelete($cid = null, $fid = null, $id = null, $slug = null)
            {
                $thread = (new ThreadVerifier([
                    'categoryId' => $cid,
                    'forumId' => $fid,
        Severity: Minor
        Found in src/controllers/ForumThreadController.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method actionMove() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

            public function actionMove($cid = null, $fid = null, $id = null, $slug = null)
            {
                $thread = (new ThreadVerifier([
                    'categoryId' => $cid,
                    'forumId' => $fid,

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        There are no issues that match your filters.

        Category
        Status