bizley/yii2-podium

View on GitHub
src/controllers/MessagesController.php

Summary

Maintainability
D
2 days
Test Coverage

Function actionNew has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionNew($user = null)
    {
        $podiumUser = User::findMe();

        if (Message::tooMany($podiumUser->id)) {
Severity: Minor
Found in src/controllers/MessagesController.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionLoad has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionLoad()
    {
        if (!Yii::$app->request->isAjax) {
            return $this->redirect(['forum/index']);
        }
Severity: Minor
Found in src/controllers/MessagesController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionNew has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionNew($user = null)
    {
        $podiumUser = User::findMe();

        if (Message::tooMany($podiumUser->id)) {
Severity: Major
Found in src/controllers/MessagesController.php - About 2 hrs to fix

    Function actionReply has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionReply($id = null)
        {
            $podiumUser = User::findMe();
    
            if (Message::tooMany($podiumUser->id)) {
    Severity: Minor
    Found in src/controllers/MessagesController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actionReply has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionReply($id = null)
        {
            $podiumUser = User::findMe();
    
            if (Message::tooMany($podiumUser->id)) {
    Severity: Minor
    Found in src/controllers/MessagesController.php - About 1 hr to fix

      Method actionLoad has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionLoad()
          {
              if (!Yii::$app->request->isAjax) {
                  return $this->redirect(['forum/index']);
              }
      Severity: Minor
      Found in src/controllers/MessagesController.php - About 1 hr to fix

        The method actionNew() has an NPath complexity of 1070. The configured NPath complexity threshold is 200.
        Open

            public function actionNew($user = null)
            {
                $podiumUser = User::findMe();
        
                if (Message::tooMany($podiumUser->id)) {

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method actionNew() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
        Open

            public function actionNew($user = null)
            {
                $podiumUser = User::findMe();
        
                if (Message::tooMany($podiumUser->id)) {

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method actionLoad() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            public function actionLoad()
            {
                if (!Yii::$app->request->isAjax) {
                    return $this->redirect(['forum/index']);
                }

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        There are no issues that match your filters.

        Category
        Status