Function actionForum
has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring. Open
public function actionForum()
{
$user = User::findMe();
$model = Meta::find()->where(['user_id' => $user->id])->limit(1)->one();
if (empty($model)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class ProfileController has an overall complexity of 52 which is very high. The configured complexity threshold is 50. Open
class ProfileController extends BaseController
{
/**
* @inheritdoc
*/
- Exclude checks
Function actionDetails
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function actionDetails()
{
$model = User::findMe();
if (empty($model)) {
return $this->redirect(['account/login']);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ProfileController.php
has 252 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace bizley\podium\controllers;
use bizley\podium\filters\AccessControl;
Method actionForum
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionForum()
{
$user = User::findMe();
$model = Meta::find()->where(['user_id' => $user->id])->limit(1)->one();
if (empty($model)) {
Method actionDetails
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionDetails()
{
$model = User::findMe();
if (empty($model)) {
return $this->redirect(['account/login']);
Method actionAdd
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionAdd($id = null)
{
if (!Yii::$app->request->isAjax) {
return $this->redirect(['forum/index']);
}
Function actionAdd
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function actionAdd($id = null)
{
if (!Yii::$app->request->isAjax) {
return $this->redirect(['forum/index']);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function actionMark
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function actionMark($id = null)
{
$model = Subscription::find()->where(['id' => $id, 'user_id' => User::loggedId()])->limit(1)->one();
if (empty($model)) {
$this->error(Yii::t('podium/flash', 'Sorry! We can not find Subscription with this ID.'));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if (!empty($model->avatar) && file_exists($oldAvatarPath)) {
if (!unlink($oldAvatarPath)) {
Log::error('Error while deleting old avatar image', null, __METHOD__);
}
}
Avoid deeply nested control flow statements. Open
if (!$model->image->saveAs($path . DIRECTORY_SEPARATOR . $model->avatar)) {
Log::error('Error while saving avatar image', null, __METHOD__);
$this->error(Yii::t('podium/flash', 'Sorry! There was an error while uploading the avatar image. Contact administrator about this problem.'));
}
Avoid deeply nested control flow statements. Open
if (!FileHelper::createDirectory($path)) {
$folderExists = false;
Log::error('Error while creating avatars folder', null, __METHOD__);
$this->error(Yii::t('podium/flash', 'Sorry! There was an error while creating the avatars folder. Contact administrator about this problem.'));
}
The method actionForum() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10. Open
public function actionForum()
{
$user = User::findMe();
$model = Meta::find()->where(['user_id' => $user->id])->limit(1)->one();
if (empty($model)) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method actionDetails() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function actionDetails()
{
$model = User::findMe();
if (empty($model)) {
return $this->redirect(['account/login']);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class ProfileController has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Open
class ProfileController extends BaseController
{
/**
* @inheritdoc
*/
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ($model->post_seen == Subscription::POST_SEEN) {
if ($model->unseen()) {
$this->success(Yii::t('podium/flash', 'Thread has been marked unseen.'));
} else {
Log::error('Error while marking thread', $model->id, __METHOD__);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 94.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ($model->post_seen == Subscription::POST_NEW) {
if ($model->seen()) {
$this->success(Yii::t('podium/flash', 'Thread has been marked seen.'));
} else {
Log::error('Error while marking thread', $model->id, __METHOD__);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 94.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
The variable $previous_new_email is not named in camelCase. Open
public function actionDetails()
{
$model = User::findMe();
if (empty($model)) {
return $this->redirect(['account/login']);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $previous_new_email is not named in camelCase. Open
public function actionDetails()
{
$model = User::findMe();
if (empty($model)) {
return $this->redirect(['account/login']);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}