Sign upLogin

bizley/yii2-podium

View on GitHub
Star
src/maintenance/Installation.php

Summary

Maintainability
D
1 day
Test Coverage

File Installation.php has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace bizley\podium\maintenance;

use bizley\podium\models\Content;
Severity: Minor
Found in src/maintenance/Installation.php - About 2 hrs to fix

    Method addContent has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addContent()
    {
        try {
            $default = Content::defaultContent();
            $this->db->createCommand()->batchInsert(
    Severity: Minor
    Found in src/maintenance/Installation.php - About 1 hr to fix

      Method addInheritedAdmin has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addInheritedAdmin()
    {
        if (empty($this->module->adminId)) {
            $this->type = self::TYPE_WARNING;
            return Yii::t('podium/flash', 'No administrator privileges have been set!');
      Severity: Minor
      Found in src/maintenance/Installation.php - About 1 hr to fix

        Method addAdmin has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function addAdmin()
    {
        if ($this->module->userComponent !== true) {
            return $this->addInheritedAdmin();
        }
        Severity: Minor
        Found in src/maintenance/Installation.php - About 1 hr to fix

          Method nextStep has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function nextStep()
    {
        $currentStep = Yii::$app->session->get(self::SESSION_KEY, 0);
        if ($currentStep === 0) {
            Yii::$app->session->set(self::SESSION_STEPS, count($this->steps));
          Severity: Minor
          Found in src/maintenance/Installation.php - About 1 hr to fix

            Method addConfig has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function addConfig()
    {
        try {
            $this->db->createCommand()->batchInsert(
                    PodiumConfig::tableName(),
            Severity: Minor
            Found in src/maintenance/Installation.php - About 1 hr to fix

              Method nextDrop has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function nextDrop()
    {
        $drops = $this->countDrops();
        if (count($drops)) {
            $currentStep = Yii::$app->session->get(self::SESSION_KEY, 0);
              Severity: Minor
              Found in src/maintenance/Installation.php - About 1 hr to fix

                Function nextDrop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function nextDrop()
    {
        $drops = $this->countDrops();
        if (count($drops)) {
            $currentStep = Yii::$app->session->get(self::SESSION_KEY, 0);
                Severity: Minor
                Found in src/maintenance/Installation.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addInheritedAdmin has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function addInheritedAdmin()
    {
        if (empty($this->module->adminId)) {
            $this->type = self::TYPE_WARNING;
            return Yii::t('podium/flash', 'No administrator privileges have been set!');
                Severity: Minor
                Found in src/maintenance/Installation.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                The method addInheritedAdmin() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function addInheritedAdmin()
    {
        if (empty($this->module->adminId)) {
            $this->type = self::TYPE_WARNING;
            return Yii::t('podium/flash', 'No administrator privileges have been set!');
                Severity: Minor
                Found in src/maintenance/Installation.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                There are no issues that match your filters.

                Category
                Status