bjerkio/crayon-api-go

View on GitHub
client/agreement_reports/update_parameters.go

Summary

Maintainability
D
1 day
Test Coverage

Method UpdateParams.WriteToRequest has 5 return statements (exceeds 4 allowed).
Open

func (o *UpdateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    if err := r.SetTimeout(o.timeout); err != nil {
        return err
    }
Severity: Major
Found in client/agreement_reports/update_parameters.go - About 35 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    // Code generated by go-swagger; DO NOT EDIT.
    
    package agreement_reports
    
    // This file was generated by the swagger tool.
    Severity: Major
    Found in client/agreement_reports/update_parameters.go and 5 other locations - About 1 day to fix
    client/assets/add_tags_async_parameters.go on lines 1..154
    client/assets/update_tags_async_parameters.go on lines 1..154
    client/azure_plans/create_subscription_parameters.go on lines 1..154
    client/invoice_profiles/update_invoice_profiles_parameters.go on lines 1..154
    client/subscriptions/update_subscriptions_parameters.go on lines 1..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 990.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status