Sign upLogin

bjerkio/gcl-slack

View on GitHub
Star

Showing 10 of 10 total issues

Function makePulumiCallback has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const makePulumiCallback = (
  type: SlackRequestType,
  options: PulumiCallbackOptions = {},
): PulumiCallbackFun => {
  if (type === 'api') {
Severity: Minor
Found in src/index.ts - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        client
      .intercept({
        path: '/services/T00000000/B00000000/with-object',
        method: 'POST',
        body: JSON.stringify({
    Severity: Major
    Found in src/__tests__/webhook.test.ts and 3 other locations - About 45 mins to fix
    src/__tests__/webhook.test.ts on lines 18..26
    src/__tests__/webhook.test.ts on lines 36..44
    src/__tests__/webhook.test.ts on lines 57..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        client
      .intercept({
        path: '/services/T00000000/B00000000/simple-message',
        method: 'POST',
        body: JSON.stringify({
    Severity: Major
    Found in src/__tests__/webhook.test.ts and 3 other locations - About 45 mins to fix
    src/__tests__/webhook.test.ts on lines 36..44
    src/__tests__/webhook.test.ts on lines 57..65
    src/__tests__/webhook.test.ts on lines 77..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        client
      .intercept({
        path: '/services/T00000000/B00000000/throw-error',
        method: 'POST',
        body: JSON.stringify({
    Severity: Major
    Found in src/__tests__/webhook.test.ts and 3 other locations - About 45 mins to fix
    src/__tests__/webhook.test.ts on lines 18..26
    src/__tests__/webhook.test.ts on lines 57..65
    src/__tests__/webhook.test.ts on lines 77..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        client
      .intercept({
        path: '/services/T00000000/B00000000/json-objects',
        method: 'POST',
        body: JSON.stringify({
    Severity: Major
    Found in src/__tests__/webhook.test.ts and 3 other locations - About 45 mins to fix
    src/__tests__/webhook.test.ts on lines 18..26
    src/__tests__/webhook.test.ts on lines 36..44
    src/__tests__/webhook.test.ts on lines 77..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        expect(
      MockedWebClient.mock.instances[0].chat.postMessage,
    ).toHaveBeenCalledWith({
      channel: 'my-channel',
      text: 'hello-world',
    Severity: Minor
    Found in src/__tests__/api.test.ts and 2 other locations - About 35 mins to fix
    src/__tests__/api.test.ts on lines 25..30
    src/__tests__/api.test.ts on lines 42..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        expect(
      MockedWebClient.mock.instances[0].chat.postMessage,
    ).toHaveBeenCalledWith({
      channel: 'my-channel',
      text: 'hello world message',
    Severity: Minor
    Found in src/__tests__/api.test.ts and 2 other locations - About 35 mins to fix
    src/__tests__/api.test.ts on lines 14..19
    src/__tests__/api.test.ts on lines 42..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        expect(
      MockedWebClient.mock.instances[0].chat.postMessage,
    ).toHaveBeenCalledWith({
      channel: 'my-channel',
      text: 'hello, world',
    Severity: Minor
    Found in src/__tests__/api.test.ts and 2 other locations - About 35 mins to fix
    src/__tests__/api.test.ts on lines 14..19
    src/__tests__/api.test.ts on lines 25..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return {
      text: entry.textPayload,
    };
    Severity: Major
    Found in src/parse-log.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return true;
      Severity: Major
      Found in src/parse-log.ts - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language