Sign upLogin

bkerley/r509-cert-validator

View on GitHub
Star
lib/r509/cert/validator/ocsp_validator.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method check_ocsp_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def check_ocsp_response(body)
          unless body.status == 0
            raise OcspError.new "OCSP status was #{body.status}, expected 0"
          end
Severity: Minor
Found in lib/r509/cert/validator/ocsp_validator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method available? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def available?
          return false unless @issuer
          return false unless aia && aia.ocsp
          return false if ocsp_uris.empty?
          return true
Severity: Minor
Found in lib/r509/cert/validator/ocsp_validator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status