Sign upLogin

blainekasten/shortcut.js

View on GitHub
Star

Showing 4 of 4 total issues

Function indexOfPolyfill has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

export default function indexOfPolyfill() : void {
  if (!Array.prototype.indexOf) {
    Array.prototype.indexOf = function indexOf(element) { // eslint-disable-line
      const length = this.length >>> 0;
Severity: Minor
Found in src/IndexOfPolyfill.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function shortcut has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function shortcut(shortcutStr:string, domNode:HTMLElement) : Object {
  // Should we envify these?
  if (!domNode || domNode.ELEMENT_NODE !== 1) {
    return error(
      `You must pass a function as a second argument to 'shortcut(string, domNode)'. Check the definition of 'shortcut("${shortcutStr}", ${domNode})`
Severity: Minor
Found in src/shortcut.js - About 1 hr to fix

Function shortcut has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function shortcut(shortcutStr:string, domNode:HTMLElement) : Object {
  // Should we envify these?
  if (!domNode || domNode.ELEMENT_NODE !== 1) {
    return error(
      `You must pass a function as a second argument to 'shortcut(string, domNode)'. Check the definition of 'shortcut("${shortcutStr}", ${domNode})`
Severity: Minor
Found in src/shortcut.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function callShortcutFunctions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function callShortcutFunctions(downKeyString: string, domNode: HTMLElement, e: KeyboardEvent) : void {
  const shortcutInstance: Object = shortcut(downKeyString, domNode);

  // shortcut is paused, so stop
  if (shortcutInstance.isPaused) {
Severity: Minor
Found in src/EventBinding.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language