Sign upLogin

bluetree-service/clover-reporter

View on GitHub
Star

Showing 11 of 11 total issues

The class Style has 18 public methods. Consider refactoring Style to keep number of public methods under 10.
Open

class Style extends SymfonyStyle
{
    /**
     * @var \Symfony\Component\Console\Helper\FormatterHelper
     */
Severity: Minor
Found in src/Console/Style.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $startTime = \microtime(true);
        $style = new Style($input, $output, $this);
Severity: Minor
Found in src/Console/Commands.php - About 1 hr to fix

    Method configure has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function configure(): void
    {
        $this->setName('reporter')
            ->setDescription('Generate coverage report based on clover report file.')
            ->setHelp('');
    Severity: Minor
    Found in src/Console/Commands.php - About 1 hr to fix

      Function processFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function processFile(\SimpleXMLElement $package, int &$key, array $list): array
    {
        if (isset($package->file)) {
            /** @var \SimpleXMLElement $file */
            foreach ($package->file as $file) {
      Severity: Minor
      Found in src/Parser.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '41', column '23').
      Open

                  throw new \InvalidArgumentException('Unable to access file: ' . $cloverFile);
      Severity: Minor
      Found in src/Parser.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method formatBlock has a boolean flag argument $large, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function formatBlock($messages, string $style, bool $large = false): self
      Severity: Minor
      Found in src/Console/Style.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '35', column '23').
      Open

                  throw new \InvalidArgumentException('File don\'t exists: ' . $cloverFile);
      Severity: Minor
      Found in src/Parser.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $startTime = \microtime(true);
        $style = new Style($input, $output, $this);
      Severity: Minor
      Found in src/Console/Commands.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method excludeDirs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $options['skip-dir'] = \explode(';', $options['skip-dir']);
        }
      Severity: Minor
      Found in src/Parser.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\BlueData\Calculation\Math' in method 'calculatePercent'.
      Open

              return Math::numberToPercent($percent, $all) ?: 0;
      Severity: Minor
      Found in src/Parser.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method fullReport uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $this->style->formatCoveredLine($number, $lineCoverage, $line);
                }
      Severity: Minor
      Found in src/Render.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Severity
      Category
      Status
      Source
      Language