bluetree-service/register

View on GitHub

Showing 10 of 10 total issues

Missing class import via use statement (line '80', column '19').
Open

        throw new \LogicException($message);
Severity: Minor
Found in src/Events/Event.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '46', column '23').
Open

            throw new \LogicException($message);
Severity: Minor
Found in src/Log.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '44', column '23').
Open

            throw new \RuntimeException('System killed by Register Exception. Unknown class: ' . $parameters[0]);
Severity: Minor
Found in src/Events/RegisterException.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method setOverrider has a boolean flag argument $onlyOnce, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function setOverrider($namespace, $overrider, $onlyOnce = false)
Severity: Minor
Found in src/Register.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '75', column '23').
Open

            throw new \InvalidArgumentException('Class don\'t exists: ' . $namespace);
Severity: Minor
Found in src/Log.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '62', column '19').
Open

        throw new \LogicException('Cannot create Log instance: ' . $object);
Severity: Minor
Found in src/Log.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '211', column '23').
Open

            throw new \InvalidArgumentException('Class don\'t exists: ' . $namespace);
Severity: Minor
Found in src/Register.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '93', column '23').
Open

            throw new \InvalidArgumentException('Class don\'t exists: ' . $namespace);
Severity: Minor
Found in src/Events/Event.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '62', column '23').
Open

            throw new \LogicException($message);
Severity: Minor
Found in src/Events/Event.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method unsetOverrider uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            unset($this->overrides[$namespace]);
        }
Severity: Minor
Found in src/Register.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language