Sign upLogin

bmya/odoo-bmya-cl

View on GitHub
Star
l10n_cl_invoice/models/invoice.py

Summary

Maintainability
C
1 day
Test Coverage

File invoice.py has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
from openerp import osv, models, fields, api, _
from openerp.osv import fields as old_fields
from openerp.exceptions import except_orm, Warning
from openerp.addons import decimal_precision as dp
Severity: Minor
Found in l10n_cl_invoice/models/invoice.py - About 3 hrs to fix

    Function _get_available_journal_document_class has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def _get_available_journal_document_class(self):
        invoice_type = self.type
        document_class_ids = []
        document_class_id = False
    Severity: Minor
    Found in l10n_cl_invoice/models/invoice.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function action_number has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def action_number(self):
        obj_sequence = self.env['ir.sequence']

        # We write document_number field with next invoice number by
        # document type
    Severity: Minor
    Found in l10n_cl_invoice/models/invoice.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_document_class_default has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_document_class_default(self, document_classes):
        if self.turn_issuer.vat_affected not in ['SI']:
            exempt_ids = [
                self.env.ref('l10n_cl_invoice.dc_y_f_dtn').id,
                self.env.ref('l10n_cl_invoice.dc_y_f_dte').id]
    Severity: Minor
    Found in l10n_cl_invoice/models/invoice.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_valid_document_letters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_valid_document_letters(
            self, cr, uid, partner_id, operation_type='sale',
            company_id=False, context=None):
        if context is None:
            context = {}
    Severity: Minor
    Found in l10n_cl_invoice/models/invoice.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_valid_document_letters has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_valid_document_letters(
    Severity: Minor
    Found in l10n_cl_invoice/models/invoice.py - About 45 mins to fix

      Function _printed_prices has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _printed_prices(self, cr, uid, ids, name, args, context=None):
      Severity: Minor
      Found in l10n_cl_invoice/models/invoice.py - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @api.one
    @api.depends('sii_document_class_id', 'sii_document_number', 'number')
    def _get_document_number(self):
        if self.sii_document_number and self.sii_document_class_id:
            document_number = (
        Severity: Major
        Found in l10n_cl_invoice/models/invoice.py and 1 other location - About 2 hrs to fix
        l10n_cl_invoice/models/account.py on lines 69..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status