Sign upLogin

bnkamalesh/errors

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for idx := len(trace) - 1; idx >= 0; idx-- {
        list := trace[idx]
        uniqueList := make([]string, 0, len(list))
        for _, line := range list {
            _, ok := lookup[line]
Severity: Major
Found in errors.go and 3 other locations - About 45 mins to fix
errors.go on lines 408..420
errors.go on lines 456..468
errors.go on lines 489..501

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for idx := len(trace) - 1; idx >= 0; idx-- {
        list := trace[idx]
        uniqueList := make([]string, 0, len(list))
        for _, line := range list {
            _, ok := lookup[line]
Severity: Major
Found in errors.go and 3 other locations - About 45 mins to fix
errors.go on lines 372..384
errors.go on lines 456..468
errors.go on lines 489..501

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for idx := len(pcs) - 1; idx >= 0; idx-- {
        list := pcs[idx]
        uniqueList := make([]uintptr, 0, len(list))
        for _, line := range list {
            _, ok := lookup[line]
Severity: Major
Found in errors.go and 3 other locations - About 45 mins to fix
errors.go on lines 372..384
errors.go on lines 408..420
errors.go on lines 456..468

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for idx := len(trace) - 1; idx >= 0; idx-- {
        list := trace[idx]
        uniqueList := make([]string, 0, len(list))
        for _, line := range list {
            _, ok := lookup[line]
Severity: Major
Found in errors.go and 3 other locations - About 45 mins to fix
errors.go on lines 372..384
errors.go on lines 408..420
errors.go on lines 489..501

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function newerrf has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func newerrf(e error, etype errType, skip int, format string, args ...interface{}) *Error {
Severity: Minor
Found in helper.go - About 35 mins to fix

    Function HasType has 5 return statements (exceeds 4 allowed).
    Open

    func HasType(err error, et errType) bool {
    if err == nil {
        return false
    }
    Severity: Major
    Found in helper.go - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language