bnomei/kirby-blueprints

View on GitHub

Showing 32 of 43 total issues

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        mixed $type = null,
        public ?string $id = null,
        public string|array|null $label = null,
        public array $properties = [],
        public string|float|null $width = null,
Severity: Minor
Found in classes/Blueprints/Schema/Field.php - About 45 mins to fix

    Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            bool|array $changeName = true,
            bool|array $replace = true,
            bool|array $delete = true,
            bool|array $read = true,
            bool|array $update = true,
    Severity: Minor
    Found in classes/Blueprints/Schema/FileOptions.php - About 45 mins to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public string|array $label = '',
              public ?Icon $icon = null,
              public ?string $id = null,
              public array $columns = [],
              public array $sections = [],
      Severity: Minor
      Found in classes/Blueprints/Schema/Tab.php - About 45 mins to fix

        Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $title,
                mixed $options = null,
                array $tabs = [],
                array $columns = [],
                array $sections = [],
        Severity: Minor
        Found in classes/Blueprints/Schema/Site.php - About 45 mins to fix

          Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  array|string $label,
                  ?Icon $icon = null,
                  ?string $id = null,
                  array $columns = [],
                  array $sections = [],
          Severity: Minor
          Found in classes/Blueprints/Schema/Tab.php - About 45 mins to fix

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    public string $title, // TODO: should be an string OR array of languages
                    public mixed $options = null,
                    public array $tabs = [],
                    public array $columns = [],
                    public array $sections = [],
            Severity: Minor
            Found in classes/Blueprints/Schema/Site.php - About 45 mins to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      public bool|array $changeName = true,
                      public bool|array $replace = true,
                      public bool|array $delete = true,
                      public bool|array $read = true,
                      public bool|array $update = true,
              Severity: Minor
              Found in classes/Blueprints/Schema/FileOptions.php - About 45 mins to fix

                Function exists has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function exists(string $key, ?int $expire = null): bool
                    {
                        $file = static::cacheFile($key);
                        if (! $file) {
                            return false;
                Severity: Minor
                Found in classes/Blueprints/BlueprintCache.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method make has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        string|float|null $width = null,
                        bool $sticky = false,
                        ?string $id = null,
                        array $sections = [],
                        array $fields = [],
                Severity: Minor
                Found in classes/Blueprints/Schema/Column.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          public string|float|null $width = null,
                          public bool $sticky = false,
                          public ?string $id = null,
                          public array $sections = [],
                          public array $fields = [],
                  Severity: Minor
                  Found in classes/Blueprints/Schema/Column.php - About 35 mins to fix

                    Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function __construct(array $props)
                        {
                            parent::__construct($props);
                    
                            // register all blueprint props to their fields
                    Severity: Minor
                    Found in classes/Blueprints/HasPublicPropertiesMappedToKirbyFields.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return false;
                    Severity: Major
                    Found in classes/Blueprints/BlueprintCache.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language