Sign upLogin

bnomei/kirby-blueprints

View on GitHub
Star

Showing 43 of 43 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct(
        public string|SectionTypes $type,
        public array $fields = [],
        public array $columns = [],
        public mixed $empty = null,
Severity: Major
Found in classes/Blueprints/Schema/Section.php and 1 other location - About 1 day to fix
classes/Blueprints/Schema/Section.php on lines 79..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 278.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function make(
        string|SectionTypes $type,
        array $fields = [],
        array $columns = [],
        mixed $empty = null,
Severity: Major
Found in classes/Blueprints/Schema/Section.php and 1 other location - About 1 day to fix
classes/Blueprints/Schema/Section.php on lines 48..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 278.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function options(
        bool|array $changeSlug = true,
        bool|array $changeStatus = true,
        bool|array $changeTemplate = true,
        bool|array $changeTitle = true,
Severity: Major
Found in classes/Blueprints/Schema/Page.php and 2 other locations - About 4 hrs to fix
classes/Blueprints/Schema/PageOptions.php on lines 26..39
classes/Blueprints/Schema/PageOptions.php on lines 41..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function make(
        bool|array $changeSlug = true,
        bool|array $changeStatus = true,
        bool|array $changeTemplate = true,
        bool|array $changeTitle = true,
Severity: Major
Found in classes/Blueprints/Schema/PageOptions.php and 2 other locations - About 4 hrs to fix
classes/Blueprints/Schema/Page.php on lines 84..101
classes/Blueprints/Schema/PageOptions.php on lines 26..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(
        public bool|array $changeSlug = true,
        public bool|array $changeStatus = true,
        public bool|array $changeTemplate = true,
        public bool|array $changeTitle = true,
Severity: Major
Found in classes/Blueprints/Schema/PageOptions.php and 2 other locations - About 4 hrs to fix
classes/Blueprints/Schema/Page.php on lines 84..101
classes/Blueprints/Schema/PageOptions.php on lines 41..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method __construct has 28 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public string|SectionTypes $type,
        public array $fields = [],
        public array $columns = [],
        public mixed $empty = null,
        public ?bool $flip = null,
Severity: Major
Found in classes/Blueprints/Schema/Section.php - About 3 hrs to fix

    Method make has 28 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string|SectionTypes $type,
        array $fields = [],
        array $columns = [],
        mixed $empty = null,
        ?bool $flip = null,
    Severity: Major
    Found in classes/Blueprints/Schema/Section.php - About 3 hrs to fix

      Function __destruct has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __destruct()
    {
        /** @var \Kirby\Cms\ModelWithContent $this */
        $key = $this->blueprintCacheKey();
        if (static::$blueprintCache) {
      Severity: Minor
      Found in classes/Blueprints/HasBlueprintCache.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function accept(
        string|array|null $extension = null,
        string|array|null $mime = null,
        ?int $maxheight = null,
        ?int $maxsize = null,
      Severity: Major
      Found in classes/Blueprints/Schema/File.php and 2 other locations - About 2 hrs to fix
      classes/Blueprints/Schema/FileAccept.php on lines 30..42
      classes/Blueprints/Schema/FileAccept.php on lines 44..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function __construct(
        public null|string|array $extension = null,
        public null|string|array $mime = null,
        public ?int $maxheight = null,
        public ?int $maxsize = null,
      Severity: Major
      Found in classes/Blueprints/Schema/FileAccept.php and 2 other locations - About 2 hrs to fix
      classes/Blueprints/Schema/File.php on lines 52..68
      classes/Blueprints/Schema/FileAccept.php on lines 44..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public static function make(
        string|array|null $extension = null,
        string|array|null $mime = null,
        ?int $maxheight = null,
        ?int $maxsize = null,
      Severity: Major
      Found in classes/Blueprints/Schema/FileAccept.php and 2 other locations - About 2 hrs to fix
      classes/Blueprints/Schema/File.php on lines 52..68
      classes/Blueprints/Schema/FileAccept.php on lines 30..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method options has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              bool|array $changeSlug = true,
        bool|array $changeStatus = true,
        bool|array $changeTemplate = true,
        bool|array $changeTitle = true,
        bool|array $create = true,
      Severity: Major
      Found in classes/Blueprints/Schema/Page.php - About 1 hr to fix

        Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public bool|array $changeSlug = true,
        public bool|array $changeStatus = true,
        public bool|array $changeTemplate = true,
        public bool|array $changeTitle = true,
        public bool|array $create = true,
        Severity: Major
        Found in classes/Blueprints/Schema/PageOptions.php - About 1 hr to fix

          Method make has 12 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  bool|array $changeSlug = true,
        bool|array $changeStatus = true,
        bool|array $changeTemplate = true,
        bool|array $changeTitle = true,
        bool|array $create = true,
          Severity: Major
          Found in classes/Blueprints/Schema/PageOptions.php - About 1 hr to fix

            Function preloadCachedBlueprints has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function preloadCachedBlueprints(): int
    {
        $cdir = static::cacheDir();
        if (! $cdir) {
            return 0;
            Severity: Minor
            Found in classes/Blueprints/BlueprintCache.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method make has 11 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    mixed $title,
        ?string $num = null,
        mixed $status = null,
        mixed $icon = null,
        mixed $image = null,
            Severity: Major
            Found in classes/Blueprints/Schema/Page.php - About 1 hr to fix

              Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      public null|string|array $extension = null,
        public null|string|array $mime = null,
        public ?int $maxheight = null,
        public ?int $maxsize = null,
        public ?int $maxwidth = null,
              Severity: Major
              Found in classes/Blueprints/Schema/FileAccept.php - About 1 hr to fix

                Method accept has 11 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        string|array|null $extension = null,
        string|array|null $mime = null,
        ?int $maxheight = null,
        ?int $maxsize = null,
        ?int $maxwidth = null,
                Severity: Major
                Found in classes/Blueprints/Schema/File.php - About 1 hr to fix

                  Method make has 11 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          string|array|null $extension = null,
        string|array|null $mime = null,
        ?int $maxheight = null,
        ?int $maxsize = null,
        ?int $maxwidth = null,
                  Severity: Major
                  Found in classes/Blueprints/Schema/FileAccept.php - About 1 hr to fix

                    Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            public mixed $title,
        public ?string $num = null,
        public mixed $status = null,
        public mixed $icon = null,
        public mixed $image = null,
                    Severity: Major
                    Found in classes/Blueprints/Schema/Page.php - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language