Sign upLogin

bnomei/kirby-mongodb

View on GitHub
Star

Showing 21 of 21 total issues

Function encodeKhulan has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

    public function encodeKhulan(?array $data = null, ?string $languageCode = null): array
    {
        if (! $data) {
            return [];
        }
Severity: Minor
Found in classes/ModelWithKhulan.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function index has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public static function index(int $iterations = 2): array
    {
        $count = 0;
        $time = microtime(true);
Severity: Minor
Found in classes/Khulan.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encodeKhulan has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function encodeKhulan(?array $data = null, ?string $languageCode = null): array
    {
        if (! $data) {
            return [];
        }
Severity: Major
Found in classes/ModelWithKhulan.php - About 3 hrs to fix

    File ModelWithKhulan.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Bnomei;
    Severity: Minor
    Found in classes/ModelWithKhulan.php - About 3 hrs to fix

      Method index has 75 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function index(int $iterations = 2): array
    {
        $count = 0;
        $time = microtime(true);
      Severity: Major
      Found in classes/Khulan.php - About 3 hrs to fix

        Method writeKhulan has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function writeKhulan(?array $data = null, ?string $languageCode = null): bool
    {
        if (option('bnomei.mongodb.khulan.write') === false) {
            return true;
        }
        Severity: Major
        Found in classes/ModelWithKhulan.php - About 2 hrs to fix

          Method decodeKhulan has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function decodeKhulan(?array $data = []): array
    {
        if (empty($data)) {
            return [];
        }
          Severity: Major
          Found in classes/ModelWithKhulan.php - About 2 hrs to fix

            Function decodeKhulan has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function decodeKhulan(?array $data = []): array
    {
        if (empty($data)) {
            return [];
        }
            Severity: Minor
            Found in classes/ModelWithKhulan.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function writeKhulan has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function writeKhulan(?array $data = null, ?string $languageCode = null): bool
    {
        if (option('bnomei.mongodb.khulan.write') === false) {
            return true;
        }
            Severity: Minor
            Found in classes/ModelWithKhulan.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function benchmark has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function benchmark(int $count = 10): void
    {
        $prefix = 'mongodb-benchmark-';
        $mongodb = $this;
        $file = kirby()->cache('bnomei.mongodb'); // neat, right? ;-)
            Severity: Minor
            Found in classes/Mongodb.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method documentsToModels has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function documentsToModels(iterable $documents): Collection|Pages|Files|Users|null
    {
        $documents = iterator_to_array($documents);

        if (empty($documents)) {
            Severity: Minor
            Found in classes/Khulan.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      foreach (kirby()->users() as $user) {
            if ($user->hasKhulan() !== true) {
                continue;
            }
            if (kirby()->multilang()) {
              Severity: Minor
              Found in classes/Khulan.php and 1 other location - About 55 mins to fix
              classes/Khulan.php on lines 26..40

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      foreach (site()->index(true) as $page) {
            if ($page->hasKhulan() !== true) {
                continue;
            }
            if (kirby()->multilang()) {
              Severity: Minor
              Found in classes/Khulan.php and 1 other location - About 55 mins to fix
              classes/Khulan.php on lines 43..57

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function documentsToModels has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function documentsToModels(iterable $documents): Collection|Pages|Files|Users|null
    {
        $documents = iterator_to_array($documents);

        if (empty($documents)) {
              Severity: Minor
              Found in classes/Khulan.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function client has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function client(): Client
    {
        if (! $this->_client) {
            if (! empty($this->options['username']) && ! empty($this->options['password'])) {
                $auth = $this->options['username'].':'.$this->options['password'].'@';
              Severity: Minor
              Found in classes/Mongodb.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return null;
              Severity: Major
              Found in classes/Khulan.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return new Users($models);
                Severity: Major
                Found in classes/Khulan.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new Collection($models);
                  Severity: Major
                  Found in classes/Khulan.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return null;
                    Severity: Major
                    Found in classes/Khulan.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return new Pages($models);
                      Severity: Major
                      Found in classes/Khulan.php - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language