bnomei/kirby3-autoid

View on GitHub
classes/AutoID.php

Summary

Maintainability
C
1 day
Test Coverage

Function index has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public static function index(bool $force = false, ?Page $root = null): int
    {
        if (static::$didIndexOnce) {
            return static::$didIndexOnce;
        }
Severity: Minor
Found in classes/AutoID.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function modified has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function modified($autoid)
    {
        if (is_string($autoid) || is_a($autoid, Field::class)) {
            return AutoIDDatabase::singleton()->modified($autoid);
        }
Severity: Minor
Found in classes/AutoID.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function index(bool $force = false, ?Page $root = null): int
    {
        if (static::$didIndexOnce) {
            return static::$didIndexOnce;
        }
Severity: Minor
Found in classes/AutoID.php - About 1 hr to fix

    Method modified has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function modified($autoid)
        {
            if (is_string($autoid) || is_a($autoid, Field::class)) {
                return AutoIDDatabase::singleton()->modified($autoid);
            }
    Severity: Minor
    Found in classes/AutoID.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return $autoid->modified();
      Severity: Major
      Found in classes/AutoID.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return count($maxModified) > 0 ? max($maxModified) : null;
        Severity: Major
        Found in classes/AutoID.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return null;
          Severity: Major
          Found in classes/AutoID.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $item->modified();
            Severity: Major
            Found in classes/AutoID.php - About 30 mins to fix

              Function find has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function find($autoid)
                  {
                      // self::index(); // NOTE: would cause loop
                      $find = AutoIDDatabase::singleton()->find($autoid);
                      if (! $find) {
              Severity: Minor
              Found in classes/AutoID.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function generate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function generate(): ?string
                  {
                      $generator = option('bnomei.autoid.generator');
                      if (is_callable($generator)) {
                          $break = intval(option('bnomei.autoid.generator-break'));
              Severity: Minor
              Found in classes/AutoID.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status