bnomei/kirby3-handlebars

View on GitHub
classes/LncFile.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function php has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function php(string $php = null): ?string
    {
        // lazy loading
        if ($php === null) {
            if ($this->target() && A::get($this->data, 'lnc') && F::exists($this->target())) {
Severity: Minor
Found in classes/LncFile.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if ($target && F::exists($target) === false) {
            $data['needsUpdate'] = true;
        } elseif ($source && $target && F::exists($target) && F::modified($source) > F::modified($target)) {
            $data['needsUpdate'] = true;
        } elseif ($source && F::modified($source) !== $data['modified']) {
Severity: Major
Found in classes/LncFile.php - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status