Sign upLogin

bnomei/kirby3-mailjet

View on GitHub
Star

Showing 12 of 12 total issues

Mailjet has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

final class Mailjet
{
    /** @var Client */
    private $client;
Severity: Minor
Found in classes/Mailjet.php - About 3 hrs to fix

    File MailjetCampaignDraft.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Bnomei;
    Severity: Minor
    Found in classes/MailjetCampaignDraft.php - About 2 hrs to fix

      Function getId has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getId($name): ?int
    {
        $id = null;
        if (ctype_digit($name)) {
            $segid = intval($name);
      Severity: Minor
      Found in classes/MailjetSegments.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getId has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getId($name): ?int
    {
        $id = null;
        if (ctype_digit($name)) {
            $id = intval($name);
      Severity: Minor
      Found in classes/MailjetContactslists.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function sender(string $email): ?int
    {
        if ($cache = $this->cacheRead('sender-' . $email)) {
            return $cache;
        }
      Severity: Major
      Found in classes/Mailjet.php and 1 other location - About 1 hr to fix
      classes/Mailjet.php on lines 203..212

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function sendername(string $email): ?string
    {
        if ($cache = $this->cacheRead('sendername-' . $email)) {
            return $cache;
        }
      Severity: Major
      Found in classes/Mailjet.php and 1 other location - About 1 hr to fix
      classes/Mailjet.php on lines 192..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method schedule has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function schedule(): bool
    {
        if (! $this->campaign || ! $this->datetime) {
            return false;
        }
      Severity: Minor
      Found in classes/MailjetCampaignDraft.php - About 1 hr to fix

        Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(array $options = [])
    {
        $defaults = [
            'debug' => option('debug'),
            'log' => option('bnomei.mailjet.log.fn'),
        Severity: Minor
        Found in classes/Mailjet.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (! $status) {
            $response = $this->client->post(Resources::$CampaigndraftSchedule, [
                'ID' => $this->campaign,
                'Body' => [
                    'Date' => substr(
          Severity: Minor
          Found in classes/MailjetCampaignDraft.php and 1 other location - About 55 mins to fix
          classes/MailjetCampaignDraft.php on lines 336..349

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 99.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (in_array($status, ['programmed', 'draft'])) {
            $response = $this->client->put(Resources::$CampaigndraftSchedule, [
                'ID' => $this->campaign,
                'Body' => [
                    'Date' => substr(
          Severity: Minor
          Found in classes/MailjetCampaignDraft.php and 1 other location - About 55 mins to fix
          classes/MailjetCampaignDraft.php on lines 320..333

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 99.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function set has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function set(string $email, array $data): bool
    {
        // find
        $response = $this->client->get(Resources::$Contactdata, [
            'id' => strtolower($email),
          Severity: Minor
          Found in classes/MailjetContactProperties.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function write(string $msg = '', string $level = 'info', ?array $context = null): bool
    {
        if ($this->logger && is_callable($this->logger)) {
            if (!$this->debug && $level == 'debug') {
                // skip but...
          Severity: Minor
          Found in classes/MailjetLog.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language