bnomei/kirby3-utm

View on GitHub
classes/Utm.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method track has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function track(string $id, array $params): bool
    {
        if ($this->option('enabled') !== true) {
            return false;
        }
Severity: Major
Found in classes/Utm.php - About 2 hrs to fix

    Function track has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function track(string $id, array $params): bool
        {
            if ($this->option('enabled') !== true) {
                return false;
            }
    Severity: Minor
    Found in classes/Utm.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(array $options = [])
        {
            $defaults = [
                'debug' => option('debug'),
                'enabled' => option('bnomei.utm.enabled'),
    Severity: Minor
    Found in classes/Utm.php - About 1 hr to fix

      Method ipstack has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function ipstack(string $ip, string $iphash = null): array
          {
              $key = $this->option('ipstack_access_key');
      
              // ip could be empty on unittests
      Severity: Minor
      Found in classes/Utm.php - About 1 hr to fix

        Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct(array $options = [])
            {
                $defaults = [
                    'debug' => option('debug'),
                    'enabled' => option('bnomei.utm.enabled'),
        Severity: Minor
        Found in classes/Utm.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in classes/Utm.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in classes/Utm.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status