Sign upLogin

boblail/hiccup

View on GitHub
Star

Showing 24 of 24 total issues

Method infer has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

      def infer(dates, options={})
        allow_null_schedules = options.fetch(:allow_null_schedules, false)
        verbosity = options.fetch(:verbosity, (options[:verbose] ? 1 : 0)) # 0, 1, or 2

        dates = extract_array_of_dates!(dates)
Severity: Minor
Found in lib/hiccup/inferable.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method infer has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def infer(dates, options={})
        allow_null_schedules = options.fetch(:allow_null_schedules, false)
        verbosity = options.fetch(:verbosity, (options[:verbose] ? 1 : 0)) # 0, 1, or 2

        dates = extract_array_of_dates!(dates)
Severity: Major
Found in lib/hiccup/inferable.rb - About 2 hrs to fix

    Method occurrences_in_month has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def occurrences_in_month(year, month)
        monthly_pattern.map do |occurrence|
          if occurrence.is_a?(Array)
            ordinal, weekday = occurrence
            wday = Date::DAYNAMES.index(weekday)
    Severity: Minor
    Found in lib/hiccup/enumerable/monthly_enumerator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate_monthly_guesses has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def generate_monthly_guesses(dates)
        histogram_of_patterns = dates.to_histogram do |date|
          [date.get_nth_wday_of_month, Date::DAYNAMES[date.wday]]
        end
        patterns_by_popularity = histogram_of_patterns.flip
    Severity: Minor
    Found in lib/hiccup/inferable/guesser.rb - About 1 hr to fix

      Method generate_monthly_guesses has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def generate_monthly_guesses(dates)
        histogram_of_patterns = dates.to_histogram do |date|
          [date.get_nth_wday_of_month, Date::DAYNAMES[date.wday]]
        end
        patterns_by_popularity = histogram_of_patterns.flip
      Severity: Minor
      Found in lib/hiccup/inferable/guesser.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method first_occurrence_on_or_before has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def first_occurrence_on_or_before(date)
        @year, @month, seed_day = date.year, date.month, date.day
        if skip > 1
          offset = months_since_schedule_start(@year, @month)
          remainder = offset % skip
      Severity: Minor
      Found in lib/hiccup/enumerable/monthly_enumerator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_recurrence has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def validate_recurrence
      case kind
      when :never;
      when :weekly;     validate_weekly_recurrence
      when :monthly;    validate_monthly_recurrence
      Severity: Minor
      Found in lib/hiccup/validatable.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method first_occurrence_on_or_after has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def first_occurrence_on_or_after(date)
        @year, @month, seed_day = date.year, date.month, date.day
        if skip > 1
          offset = months_since_schedule_start(@year, @month)
          remainder = offset % skip
      Severity: Minor
      Found in lib/hiccup/enumerable/monthly_enumerator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method human_ordinalize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def human_ordinalize(map={})
    map.key?(self) ? map[self] : (begin
      if self < -1
        "#{(-self).human_ordinalize} to last"
      else
      Severity: Minor
      Found in lib/hiccup/core_ext/integer.rb - About 1 hr to fix

        Method first_occurrence_on_or_after has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def first_occurrence_on_or_after(date)
        result = nil
        wday = date.wday
        wday_pattern.each do |wd|
          wd = wd + 7 if wd < wday
        Severity: Minor
        Found in lib/hiccup/enumerable/weekly_enumerator.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method first_occurrence_on_or_before has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def first_occurrence_on_or_before(date)
        result = nil
        wday = date.wday
        wday_pattern.each do |wd|
          wd = wd - 7 if wd > wday
        Severity: Minor
        Found in lib/hiccup/enumerable/weekly_enumerator.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method human_ordinalize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def human_ordinalize(map={})
    map.key?(self) ? map[self] : (begin
      if self < -1
        "#{(-self).human_ordinalize} to last"
      else
        Severity: Minor
        Found in lib/hiccup/core_ext/integer.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_weekly_guesses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def generate_weekly_guesses(dates)
        [].tap do |guesses|
          histogram_of_wdays = dates.to_histogram do |date|
            Date::DAYNAMES[date.wday]
          end
        Severity: Minor
        Found in lib/hiccup/inferable/guesser.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method first_occurrence_on_or_before has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def first_occurrence_on_or_before(date)
        @year = date.year
        @year -= 1 if (date.month < month) or (date.month == month and date.day < day)

        remainder = (@year - start_date.year) % skip
        Severity: Minor
        Found in lib/hiccup/enumerable/annually_enumerator.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method first_occurrence_on_or_after has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def first_occurrence_on_or_after(date)
        @year = date.year
        @year += 1 if (date.month > month) or (date.month == month and date.day > day)

        remainder = (@year - start_date.year) % skip
        Severity: Minor
        Found in lib/hiccup/enumerable/annually_enumerator.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    enumerate_by_popularity(patterns_by_popularity) do |patterns|
              next if patterns.length > max_complexity
              guesses << @klass.new.tap do |schedule|
                schedule.kind = :monthly
                schedule.start_date = @start_date
        Severity: Minor
        Found in lib/hiccup/inferable/guesser.rb and 2 other locations - About 35 mins to fix
        lib/hiccup/inferable/guesser.rb on lines 74..81
        lib/hiccup/inferable/guesser.rb on lines 115..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    enumerate_by_popularity(days_by_popularity) do |days|
              next if days.length > max_complexity
              guesses << @klass.new.tap do |schedule|
                schedule.kind = :monthly
                schedule.start_date = @start_date
        Severity: Minor
        Found in lib/hiccup/inferable/guesser.rb and 2 other locations - About 35 mins to fix
        lib/hiccup/inferable/guesser.rb on lines 85..92
        lib/hiccup/inferable/guesser.rb on lines 115..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    enumerate_by_popularity(wdays_by_popularity) do |wdays|
              next if wdays.length > max_complexity
              guesses << @klass.new.tap do |schedule|
                schedule.kind = :weekly
                schedule.start_date = @start_date
        Severity: Minor
        Found in lib/hiccup/inferable/guesser.rb and 2 other locations - About 35 mins to fix
        lib/hiccup/inferable/guesser.rb on lines 74..81
        lib/hiccup/inferable/guesser.rb on lines 85..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def n_occurrences_on_or_before(limit, date, options={})
      exceptions = options.fetch(:except, [])
      occurrences = []
      enum = enumerator.new(self, date)
      while (occurrence = enum.prev) && occurrences.length < limit
        Severity: Minor
        Found in lib/hiccup/enumerable.rb and 1 other location - About 30 mins to fix
        lib/hiccup/enumerable.rb on lines 100..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def n_occurrences_on_or_after(limit, date, options={})
      exceptions = options.fetch(:except, [])
      occurrences = []
      enum = enumerator.new(self, date)
      while (occurrence = enum.next) && occurrences.length < limit
        Severity: Minor
        Found in lib/hiccup/enumerable.rb and 1 other location - About 30 mins to fix
        lib/hiccup/enumerable.rb on lines 80..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language