Sign upLogin

boehm-s/fun-php

View on GitHub
Star
src/internals/_arity.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '9', column '32').
Open

        $reflectionClass = new ReflectionClass($class);
Severity: Minor
Found in src/internals/_arity.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '13', column '27').
Open

        $reflection = new ReflectionFunction($fn);
Severity: Minor
Found in src/internals/_arity.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method _arity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

    } else {
        $reflection = new ReflectionFunction($fn);
        $arguments = $reflection->getParameters();
    }
Severity: Minor
Found in src/internals/_arity.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid variables with short names like $fn. Configured minimum length is 3.
Open

function _arity(Callable $fn) {
Severity: Minor
Found in src/internals/_arity.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fn. Configured minimum length is 3.
Open

function _call_fn_right_arity(callable $fn, array $args) {
Severity: Minor
Found in src/internals/_arity.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

PHP keywords must be lowercase; expected "callable" but found "Callable"
Open

function _arity(Callable $fn) {
Severity: Minor
Found in src/internals/_arity.php by phpcodesniffer

Opening brace should be on a new line
Open

function _arity(Callable $fn) {
Severity: Minor
Found in src/internals/_arity.php by phpcodesniffer

Opening brace should be on a new line
Open

function _call_fn_right_arity(callable $fn, array $args) {
Severity: Minor
Found in src/internals/_arity.php by phpcodesniffer

There are no issues that match your filters.

Category
Status