Sign upLogin

boehm-s/fun-php

View on GitHub
Star
src/internals/_curry1.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _curry1 uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return call_user_func_array($fn, $args);
        }
Severity: Minor
Found in src/internals/_curry1.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first side effect is on line 3.
Open

<?php
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

Avoid variables with short names like $a. Configured minimum length is 3.
Open

    return function ($a = null) use ($fn) {
Severity: Minor
Found in src/internals/_curry1.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fn. Configured minimum length is 3.
Open

function _curry1($fn) {
Severity: Minor
Found in src/internals/_curry1.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Expected 1 space after FUNCTION keyword; 0 found
Open

            return function(...$args) use ($fn) { return _curry1($fn)(...$args); };
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

Each PHP statement must be on a line by itself
Open

            return function(...$args) use ($fn) { return _curry1($fn)(...$args); };
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

Opening brace should be on a new line
Open

function _curry1($fn) {
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

Closing brace must be on a line by itself
Open

            return function(...$args) use ($fn) { return _curry1($fn)(...$args); };
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

Opening brace must be the last content on the line
Open

            return function(...$args) use ($fn) { return _curry1($fn)(...$args); };
Severity: Minor
Found in src/internals/_curry1.php by phpcodesniffer

There are no issues that match your filters.

Category
Status