boehm-s/fun-php

View on GitHub
src/internals/_reduce.php

Summary

Maintainability
A
0 mins
Test Coverage

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first side effect is on line 3.
Open

<?php
Severity: Minor
Found in src/internals/_reduce.php by phpcodesniffer

Avoid variables with short names like $fn. Configured minimum length is 3.
Open

function _reduce(Callable $fn, iterable $array, $identity) {
Severity: Minor
Found in src/internals/_reduce.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

PHP keywords must be lowercase; expected "callable" but found "Callable"
Open

function _reduce(Callable $fn, iterable $array, $identity) {
Severity: Minor
Found in src/internals/_reduce.php by phpcodesniffer

Opening brace should be on a new line
Open

function _reduce(Callable $fn, iterable $array, $identity) {
Severity: Minor
Found in src/internals/_reduce.php by phpcodesniffer

There are no issues that match your filters.

Category
Status