Sign upLogin

bogdanRada/washout_builder

View on GitHub
Star
app/helpers/washout_builder_complex_type_helper.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method create_element_type_html has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def create_element_type_html(pre, element, element_description)
    element_description = element_description.blank? ? nil : element_description.fetch(element.name.to_s.downcase, '')
    element.type = 'string' if element.type == 'text'
    element.type = 'integer' if element.type == 'int'
    if WashoutBuilder::Type::BASIC_TYPES.include?(element.type)
Severity: Minor
Found in app/helpers/washout_builder_complex_type_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Prefer to_s over string interpolation.
Open

    complex_class_content = element.multiplied ? "Array of #{real_class}" : "#{real_class}"
Severity: Minor
Found in app/helpers/washout_builder_complex_type_helper.rb by rubocop

This cop checks for strings that are just an interpolated expression.

Example:

# bad
"#{@var}"

# good
@var.to_s

# good if @var is already a String
@var

There are no issues that match your filters.

Category
Status