Sign upLogin

bogdanRada/washout_builder

View on GitHub
Star
app/helpers/washout_builder_method_arguments_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method create_method_argument_complex_element has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def create_method_argument_complex_element(pre, param, use_spacer, spacer, complex_class)
Severity: Minor
Found in app/helpers/washout_builder_method_arguments_helper.rb - About 35 mins to fix

    Method create_method_argument_element has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_method_argument_element(pre, param, mlen)
    spacer = '    '
    complex_class = param.find_complex_class_name
    use_spacer = mlen > 1 ? true : false
    if WashoutBuilder::Type::BASIC_TYPES.include?(param.type)
    Severity: Minor
    Found in app/helpers/washout_builder_method_arguments_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    This conditional expression can just be replaced by mlen > 1.
    Open

        use_spacer = mlen > 1 ? true : false
    Severity: Minor
    Found in app/helpers/washout_builder_method_arguments_helper.rb by rubocop

    This cop checks for redundant returning of true/false in conditionals.

    Example:

    # bad
x == y ? true : false

# bad
if x == y
  true
else
  false
end

# good
x == y

# bad
x == y ? false : true

# good
x != y

    Prefer to_s over string interpolation.
    Open

        argument_content = param.multiplied ? "Array of #{real_class}" : "#{real_class}"
    Severity: Minor
    Found in app/helpers/washout_builder_method_arguments_helper.rb by rubocop

    This cop checks for strings that are just an interpolated expression.

    Example:

    # bad
"#{@var}"

# good
@var.to_s

# good if @var is already a String
@var

    There are no issues that match your filters.

    Category
    Status