bombbomb/BBCore

View on GitHub

Showing 28 of 28 total issues

Function sendRequest has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

BBCore.prototype.sendRequest = function (method, params, success, error) {
    if (typeof params === "function") {
        success = params;
    }
    if (typeof method === "object") {
Severity: Minor
Found in src/modules/bbcore.api.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File bbcore.auth.js has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Authenticates a user using their Email Address (User Id) and Password
 * @arg {string} uid
 * @arg {string} pwd
 * @arg {responseSuccess} success
Severity: Minor
Found in src/modules/bbcore.auth.js - About 5 hrs to fix

    Function validateSession has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    BBCore.prototype.validateSession = function (onSuccess, onError) {
    
        var oAuthPayload = this.getOAuthPayload();
        var inst = this;
        var authCode = /[\?\#].*&*(access_token|code)=([^&]+)/gi.exec(window.location.href);
    Severity: Minor
    Found in src/modules/bbcore.auth.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendRequest has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    BBCore.prototype.sendRequest = function (method, params, success, error) {
        if (typeof params === "function") {
            success = params;
        }
        if (typeof method === "object") {
    Severity: Major
    Found in src/modules/bbcore.api.js - About 3 hrs to fix

      Function startVideoRecorder has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      BBCore.prototype.startVideoRecorder = function (opts, recordComplete) {
          if (typeof opts === "function") {
              recordComplete = opts;
              opts = null;
          }
      Severity: Major
      Found in src/modules/bbcore.videoRecorder.js - About 2 hrs to fix

        Function validateSession has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        BBCore.prototype.validateSession = function (onSuccess, onError) {
        
            var oAuthPayload = this.getOAuthPayload();
            var inst = this;
            var authCode = /[\?\#].*&*(access_token|code)=([^&]+)/gi.exec(window.location.href);
        Severity: Major
        Found in src/modules/bbcore.auth.js - About 2 hrs to fix

          Function BBCore has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function BBCore(options) {
              this.userEmail = "";
              this.userId = "";
              this.clientId = "";
              this.accessToken = "";
          Severity: Minor
          Found in src/bbcore.js - About 1 hr to fix

            Function videoQuickSend has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            BBCore.prototype.videoQuickSend = function (opts, onSuccess) {
                // TODO; this should be calling the api
                var reqDetails = {
                        method: 'VideoQuickSend',
                        subject: 'QuickSend from BombBomb',
            Severity: Minor
            Found in src/modules/bbcore.video.js - About 1 hr to fix

              Function getEmbeddedRecorderUrl has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              BBCore.prototype.getEmbeddedRecorderUrl = function (options, onComplete) {
                  if (typeof options === "function") {
                      onComplete = options;
                      options = {};
                  }
              Severity: Minor
              Found in src/modules/bbcore.videoRecorder.js - About 1 hr to fix

                Function videoQuickSend has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                BBCore.prototype.videoQuickSend = function (opts, onSuccess) {
                    // TODO; this should be calling the api
                    var reqDetails = {
                            method: 'VideoQuickSend',
                            subject: 'QuickSend from BombBomb',
                Severity: Minor
                Found in src/modules/bbcore.video.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function validateOAuthCode has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                BBCore.prototype.validateOAuthCode = function(authCode, onSuccess, onError) {
                
                    var inst = this,
                        credentials = this.credentials,
                        authRequestPayload = {
                Severity: Minor
                Found in src/modules/bbcore.auth.js - About 1 hr to fix

                  Function getVideos has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  BBCore.prototype.getVideos = function (options, success) {
                      var defaults = {
                          updatedSince: '',
                          page: null,
                          pageSize: 50
                  Severity: Minor
                  Found in src/modules/bbcore.video.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function login has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  BBCore.prototype.login = function (uid, pwd, success) {
                      if (arguments.length < 2 && (this.credentials && this.credentials.clientIdentifier))
                      {
                          var locationTarget = window;
                          if (typeof usePopup !== 'undefined')
                  Severity: Minor
                  Found in src/modules/bbcore.auth.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  BBCore.prototype.login = function (uid, pwd, success) {
                      if (arguments.length < 2 && (this.credentials && this.credentials.clientIdentifier))
                      {
                          var locationTarget = window;
                          if (typeof usePopup !== 'undefined')
                  Severity: Minor
                  Found in src/modules/bbcore.auth.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    BBCore.prototype.getVideoStatus = function (vidId, success) {
                        if (!vidId) {
                            return;
                        }
                        this.sendRequest({method: "getVideoStatus", id: vidId}, success);
                    Severity: Major
                    Found in src/modules/bbcore.video.js and 1 other location - About 1 hr to fix
                    src/modules/bbcore.video.js on lines 11..16

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    BBCore.prototype.getVideo = function (vidId, success) {
                        if (!vidId) {
                            return;
                        }
                        this.sendRequest({method: "GetVideos", video_id: vidId}, success);
                    Severity: Major
                    Found in src/modules/bbcore.video.js and 1 other location - About 1 hr to fix
                    src/modules/bbcore.video.js on lines 46..51

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function BBCore has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function BBCore(options) {
                        this.userEmail = "";
                        this.userId = "";
                        this.clientId = "";
                        this.accessToken = "";
                    Severity: Minor
                    Found in src/bbcore.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function __updateSession has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    BBCore.prototype.__updateSession = function (respObj, done) {
                        if (respObj.status === "success") {
                            if (respObj.info.userId)
                            {
                                this.userId = respObj.info.userId;
                    Severity: Minor
                    Found in src/modules/bbcore.auth.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                if (onError) onError();
                    Severity: Major
                    Found in src/modules/bbcore.auth.js - About 45 mins to fix

                      Function __mergeProperties has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      BBCore.prototype.__mergeProperties = function (base, addl) {
                          if (!base)
                          {
                              base = this;
                          }
                      Severity: Minor
                      Found in src/bbcore.js - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language