Sign upLogin

bombbomb/BBCore

View on GitHub
Star
src/modules/bbcore.auth.js

Summary

Maintainability
D
2 days
Test Coverage

File bbcore.auth.js has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Authenticates a user using their Email Address (User Id) and Password
 * @arg {string} uid
 * @arg {string} pwd
 * @arg {responseSuccess} success
Severity: Minor
Found in src/modules/bbcore.auth.js - About 5 hrs to fix

    Function validateSession has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    BBCore.prototype.validateSession = function (onSuccess, onError) {

    var oAuthPayload = this.getOAuthPayload();
    var inst = this;
    var authCode = /[\?\#].*&*(access_token|code)=([^&]+)/gi.exec(window.location.href);
    Severity: Minor
    Found in src/modules/bbcore.auth.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateSession has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    BBCore.prototype.validateSession = function (onSuccess, onError) {

    var oAuthPayload = this.getOAuthPayload();
    var inst = this;
    var authCode = /[\?\#].*&*(access_token|code)=([^&]+)/gi.exec(window.location.href);
    Severity: Major
    Found in src/modules/bbcore.auth.js - About 2 hrs to fix

      Function validateOAuthCode has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      BBCore.prototype.validateOAuthCode = function(authCode, onSuccess, onError) {

    var inst = this,
        credentials = this.credentials,
        authRequestPayload = {
      Severity: Minor
      Found in src/modules/bbcore.auth.js - About 1 hr to fix

        Function login has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        BBCore.prototype.login = function (uid, pwd, success) {
    if (arguments.length < 2 && (this.credentials && this.credentials.clientIdentifier))
    {
        var locationTarget = window;
        if (typeof usePopup !== 'undefined')
        Severity: Minor
        Found in src/modules/bbcore.auth.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        BBCore.prototype.login = function (uid, pwd, success) {
    if (arguments.length < 2 && (this.credentials && this.credentials.clientIdentifier))
    {
        var locationTarget = window;
        if (typeof usePopup !== 'undefined')
        Severity: Minor
        Found in src/modules/bbcore.auth.js - About 1 hr to fix

          Function __updateSession has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          BBCore.prototype.__updateSession = function (respObj, done) {
    if (respObj.status === "success") {
        if (respObj.info.userId)
        {
            this.userId = respObj.info.userId;
          Severity: Minor
          Found in src/modules/bbcore.auth.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if (onError) onError();
          Severity: Major
          Found in src/modules/bbcore.auth.js - About 45 mins to fix

            Function __getOAuthAccessPayload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            BBCore.prototype.__getOAuthAccessPayload = function(payload) {
    var jsonPayload = typeof payload === 'string' ? JSON.parse(payload) : payload,
        jwtObj = null;
    if (jsonPayload)
    {
            Severity: Minor
            Found in src/modules/bbcore.auth.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateOAuthCode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            BBCore.prototype.validateOAuthCode = function(authCode, onSuccess, onError) {

    var inst = this,
        credentials = this.credentials,
        authRequestPayload = {
            Severity: Minor
            Found in src/modules/bbcore.auth.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            BBCore.prototype.getKey = function () {
    return this.accessToken ? this.accessToken : this.storage.getItem("access_token");
};
            Severity: Minor
            Found in src/modules/bbcore.auth.js and 1 other location - About 40 mins to fix
            src/modules/bbcore.auth.js on lines 474..476

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            BBCore.prototype.getJsonWebToken = function () {
    return this.jsonWebToken ? this.jsonWebToken : this.storage.getItem("jsonWebToken");
};
            Severity: Minor
            Found in src/modules/bbcore.auth.js and 1 other location - About 40 mins to fix
            src/modules/bbcore.auth.js on lines 263..265

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            BBCore.prototype.clearJsonWebToken = function () {
    this.jsonWebToken = null;
    this.storage.removeItem('jsonWebToken');
};
            Severity: Minor
            Found in src/modules/bbcore.auth.js and 1 other location - About 40 mins to fix
            src/modules/bbcore.auth.js on lines 266..269

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            BBCore.prototype.clearKey = function () {
    this.accessToken = null;
    this.storage.removeItem('access_token');
};
            Severity: Minor
            Found in src/modules/bbcore.auth.js and 1 other location - About 40 mins to fix
            src/modules/bbcore.auth.js on lines 477..480

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status