Sign upLogin

bomquote/transistor

View on GitHub
Star
examples/cny_exchange_rate.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _get_usd_row_cells has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

def _get_usd_row_cells(trs):
    """
    Get the table cells from the webpage we need for the exchange rate data.
    :param trs:  browser.get_current_page().find_all("tr")
    :return: list(): a list of cells
Severity: Minor
Found in examples/cny_exchange_rate.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function _get_usd_row_cells. (7)
Open

def _get_usd_row_cells(trs):
    """
    Get the table cells from the webpage we need for the exchange rate data.
    :param trs:  browser.get_current_page().find_all("tr")
    :return: list(): a list of cells
Severity: Minor
Found in examples/cny_exchange_rate.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Avoid deeply nested control flow statements.
Open

                    for cell in usd_row:
                        if '\n' not in cell:
                            cells.append(cell)
    return cells
Severity: Major
Found in examples/cny_exchange_rate.py - About 45 mins to fix

    No newline at end of file
    Open

        return str(rate), str(time)
    Severity: Minor
    Found in examples/cny_exchange_rate.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    There are no issues that match your filters.

    Category
    Status